[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7319: Move offline seg download code to OfflineTableManager

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #7319:
URL: https://github.com/apache/pinot/pull/7319#discussion_r692458669



##########
File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentOnlineOfflineStateModelFactory.java
##########
@@ -208,7 +205,9 @@ public void onBecomeDroppedFromOffline(Message message, NotificationContext cont
       try {
         segmentLock.lock();
 
-        final File segmentDir = new File(_fetcherAndLoader.getSegmentLocalDirectory(tableNameWithType, segmentName));
+        TableDataManager tableDataManager = _instanceDataManager.getTableDataManager(tableNameWithType);
+        Preconditions.checkNotNull(tableDataManager);

Review comment:
       TableDataManager might not exist if there is no segment loaded for this table yet. Can we read the segment data dir from the `_instanceDataManager`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org