[GitHub] [maven-common-artifact-filters] gnodet commented on pull request #15: Big speed improvements for patterns that do not contain any wildcard

[GitBox <gi...@apache.org>]

gnodet commented on pull request #15:
URL: https://github.com/apache/maven-common-artifact-filters/pull/15#issuecomment-766796366


   @michael-o I'm all for improving things, but it seems all the comments are not in my code.  They do appear in the diffs because I copied the old class into the test dir so that we can be able to make performance tests and compare the old and new version.  The problems you mention do appear in the current code https://github.com/apache/maven-common-artifact-filters/blob/master/src/main/java/org/apache/maven/shared/artifact/filter/PatternIncludesArtifactFilter.java#L355
   Btw, this is sad this speed boost did miss the release which has been done 3 days ago :-(


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org