[GitHub] [orc] wgtmac commented on a diff in pull request #1323: ORC-1315:[C++] Fix byte to integer conversions fail on platforms with unsigned char type

[GitBox <gi...@apache.org>]

wgtmac commented on code in PR #1323:
URL: https://github.com/apache/orc/pull/1323#discussion_r1031009829


##########
c++/src/ByteRLE.cc:
##########
@@ -354,7 +354,7 @@ namespace orc {
     if (bufferStart == bufferEnd) {
       nextBuffer();
     }
-    return *(bufferStart++);
+    return static_cast<signed char>(*(bufferStart++));

Review Comment:
   How about changing the return type from `signed char` to `int8_t`? But this may introduce a larger change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org