You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by jm...@apache.org on 2005/06/02 02:07:44 UTC
svn commit: r179467 - /spamassassin/trunk/lib/Mail/SpamAssassin.pm
Author: jm
Date: Wed Jun 1 17:07:43 2005
New Revision: 179467
URL: http://svn.apache.org/viewcvs?rev=179467&view=rev
Log:
oops, fix wrong-way-around .= and = usage when reading config files
Modified:
spamassassin/trunk/lib/Mail/SpamAssassin.pm
Modified: spamassassin/trunk/lib/Mail/SpamAssassin.pm
URL: http://svn.apache.org/viewcvs/spamassassin/trunk/lib/Mail/SpamAssassin.pm?rev=179467&r1=179466&r2=179467&view=diff
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin.pm (original)
+++ spamassassin/trunk/lib/Mail/SpamAssassin.pm Wed Jun 1 17:07:43 2005
@@ -1414,8 +1414,8 @@
my $txt = '';
if (open (IN, "<".$path)) {
- $txt .= "file start $path\n";
- $txt = join ('', <IN>);
+ $txt = "file start $path\n";
+ $txt .= join ('', <IN>);
# add an extra \n in case file did not end in one.
$txt .= "\nfile end $path\n";
close IN;
Re: svn commit: r179467 - /spamassassin/trunk/lib/Mail/SpamAssassin.pm
Posted by Daniel Quinlan <qu...@pathname.com>.
jm@apache.org writes:
> if (open (IN, "<".$path)) {
> $txt .= join ('', <IN>);
This seems like memory bloat. Why don't we just stream this into the
configuration parser?
Daniel
--
Daniel Quinlan
http://www.pathname.com/~quinlan/