You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sfirke (via GitHub)" <gi...@apache.org> on 2023/04/20 16:28:35 UTC

[GitHub] [superset] sfirke commented on pull request #23751: fix(mssql): apply top after distinct

sfirke commented on PR #23751:
URL: https://github.com/apache/superset/pull/23751#issuecomment-1516622023

   This looks great!  I haven't tried it but the code makes sense to me, looks minimal and low-risk of side effects.  Thanks @villebro !  Maybe note that it would fix https://github.com/apache/superset/issues/21027.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org