You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kylin.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/11/20 09:52:01 UTC
Review Request 63946: KYLIN-3049 Filter the invalid zero value of
"Auto Merge Thresholds" parameter when you create or upate a cube.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63946/
-----------------------------------------------------------
Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.
Bugs: KYLIN-3049
https://issues.apache.org/jira/browse/KYLIN-3049
Repository: kylin
Description
-------
1. Open the Model page;
2. Create a new cube, click the "New Thresholds" button in the "Refresh Setting" tab, and don't input any value, then complete the follow steps, at last save it;
3. Choose the cube you just created, go to the "Refresh Setting" tab, you will find the zero hours in "Auto Merge Thresholds" list, which is invalid but saved in the server;
4. Similarly, update a existent cube, do the same steps, you will also find the invalid zero value saved in the server.
As we know, the zero value of "Auto Merge Thresholds" parameter is invalid, so we should filter it before sending it to server.
Diffs
-----
webapp/app/js/utils/utils.js 30ad261
Diff: https://reviews.apache.org/r/63946/diff/1/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 63946: KYLIN-3049 Filter the invalid zero value of
"Auto Merge Thresholds" parameter when you create or upate a cube.
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63946/
-----------------------------------------------------------
(Updated 十一月 27, 2017, 9:27 a.m.)
Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.
Changes
-------
Thanks for your suggestion, I have updated the patch.
1. modify the $scope.prepareCube function
2. add the function 'removeElementInArrayByValue' in utils.js
please check it, thanks!
Bugs: KYLIN-3049
https://issues.apache.org/jira/browse/KYLIN-3049
Repository: kylin
Description
-------
1. Open the Model page;
2. Create a new cube, click the "New Thresholds" button in the "Refresh Setting" tab, and don't input any value, then complete the follow steps, at last save it;
3. Choose the cube you just created, go to the "Refresh Setting" tab, you will find the zero hours in "Auto Merge Thresholds" list, which is invalid but saved in the server;
4. Similarly, update a existent cube, do the same steps, you will also find the invalid zero value saved in the server.
As we know, the zero value of "Auto Merge Thresholds" parameter is invalid, so we should filter it before sending it to server.
Diffs (updated)
-----
webapp/app/js/controllers/cubeEdit.js 5f78b61
webapp/app/js/utils/utils.js 30ad261
Diff: https://reviews.apache.org/r/63946/diff/3/
Changes: https://reviews.apache.org/r/63946/diff/2-3/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 63946: KYLIN-3049 Filter the invalid zero value of
"Auto Merge Thresholds" parameter when you create or upate a cube.
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63946/
-----------------------------------------------------------
(Updated 十一月 24, 2017, 7:07 a.m.)
Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.
Changes
-------
I have reverted the utils.js, and modified the cubeEdit.js, wichi can only filter the zero value when you edit a cure or add one new cube, and it doesn't effect the model operation.
Bugs: KYLIN-3049
https://issues.apache.org/jira/browse/KYLIN-3049
Repository: kylin
Description
-------
1. Open the Model page;
2. Create a new cube, click the "New Thresholds" button in the "Refresh Setting" tab, and don't input any value, then complete the follow steps, at last save it;
3. Choose the cube you just created, go to the "Refresh Setting" tab, you will find the zero hours in "Auto Merge Thresholds" list, which is invalid but saved in the server;
4. Similarly, update a existent cube, do the same steps, you will also find the invalid zero value saved in the server.
As we know, the zero value of "Auto Merge Thresholds" parameter is invalid, so we should filter it before sending it to server.
Diffs (updated)
-----
webapp/app/js/controllers/cubeEdit.js 5f78b61
Diff: https://reviews.apache.org/r/63946/diff/2/
Changes: https://reviews.apache.org/r/63946/diff/1-2/
Testing
-------
Thanks,
pengjianhua