[GitHub] [ignite-3] zstan commented on a change in pull request #662: IGNITE-16547 MERGE operation support.

[GitBox <gi...@apache.org>]

zstan commented on a change in pull request #662:
URL: https://github.com/apache/ignite-3/pull/662#discussion_r807931595



##########
File path: modules/schema/src/main/java/org/apache/ignite/internal/schema/row/ExpandableByteBuf.java
##########
@@ -172,12 +172,12 @@ public void putBytes(int off, byte[] val) {
     public int putString(int off, String val, CharsetEncoder encoder) throws CharacterCodingException {
         ensureCapacity(off);
 
-        buf.position(off);
-
         if (val.isEmpty()) {
             return 0;
         }
 
+        buf.position(off);

Review comment:
       check the history ) previous changes was mine too ) what problem i hide and where some explanation or test for it ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org