You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <ro...@mesosphe.re> on 2013/07/18 21:52:54 UTC

Review Request 12731: Remove 'Slaves' list from index

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12731/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos-git


Description
-------

Frameworks are now front and center. Slaves can still be accessed via the navbar, but they no longer take valuable space and time on the homepage of the web UI.

Original review: https://reviews.apache.org/r/12604/


Diffs
-----

  src/webui/master/static/home.html d45cc944f95d6fa0539e341982391024d0cb0514 

Diff: https://reviews.apache.org/r/12731/diff/


Testing
-------

* Rendered the homepage
* Clicked the "Slaves" tab in the navbar to verify table renders


Thanks,

Ross Allen


Re: Review Request 12731: Remove 'Slaves' list from index

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12731/#review23450
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On July 18, 2013, 7:52 p.m., Ross Allen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12731/
> -----------------------------------------------------------
> 
> (Updated July 18, 2013, 7:52 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Frameworks are now front and center. Slaves can still be accessed via the navbar, but they no longer take valuable space and time on the homepage of the web UI.
> 
> Original review: https://reviews.apache.org/r/12604/
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/home.html d45cc944f95d6fa0539e341982391024d0cb0514 
> 
> Diff: https://reviews.apache.org/r/12731/diff/
> 
> 
> Testing
> -------
> 
> * Rendered the homepage
> * Clicked the "Slaves" tab in the navbar to verify table renders
> 
> 
> Thanks,
> 
> Ross Allen
> 
>


Re: Review Request 12731: Remove 'Slaves' list from index

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12731/#review23449
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On July 18, 2013, 7:52 p.m., Ross Allen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12731/
> -----------------------------------------------------------
> 
> (Updated July 18, 2013, 7:52 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Frameworks are now front and center. Slaves can still be accessed via the navbar, but they no longer take valuable space and time on the homepage of the web UI.
> 
> Original review: https://reviews.apache.org/r/12604/
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/home.html d45cc944f95d6fa0539e341982391024d0cb0514 
> 
> Diff: https://reviews.apache.org/r/12731/diff/
> 
> 
> Testing
> -------
> 
> * Rendered the homepage
> * Clicked the "Slaves" tab in the navbar to verify table renders
> 
> 
> Thanks,
> 
> Ross Allen
> 
>