You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/03/26 18:30:19 UTC
[GitHub] [lucene-solr] dsmiley commented on issue #1261: SOLR-14260: Make
SchemaRegistryProvider pluggable in HttpClientUtil
dsmiley commented on issue #1261: SOLR-14260: Make SchemaRegistryProvider pluggable in HttpClientUtil
URL: https://github.com/apache/lucene-solr/pull/1261#issuecomment-604602628
We agree connectionSocketFactoryRegistryProvider is a bit much. I had dropped "Provider" as it seems kinda meta and somewhat redundant with the word also having a "Factory" (Provider ~ Factory), but I can see it could be there. I like your proposal of keeping either one of connection or socket. I propose keep the word socket and drop connection. Or abbreviate "connection" to "conn" which is sufficiently shorter to make me feel better about the fully complete word. Ah naming...
I can see generics may be an issue so yeah keep the class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org