[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1292: testcase for /dev/crypto

[GitBox <gi...@apache.org>]

pkarashchenko commented on code in PR #1292:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1292#discussion_r957151390


##########
testing/crypto/hmac.c:
##########
@@ -0,0 +1,230 @@
+/****************************************************************************
+ * apps/testing/crypto/hmac.c
+ * Copyright (c) 2008 Damien Bergamini <da...@free.fr>
+ *
+ * Permission to use, copy, modify, and distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <err.h>
+#include <stdio.h>
+#include <fcntl.h>
+#include <crypto/cryptodev.h>
+#include <string.h>
+#include <sys/ioctl.h>
+#include <crypto/md5.h>
+#include <crypto/sha1.h>
+#include <crypto/sha2.h>
+
+struct tb
+{
+  char *key;

Review Comment:
   Are this tests targeted to run on PC or on the MCU? If it is on MCU, then we need to add `FAR` to pointers



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org