[GitHub] zheng-da commented on a change in pull request #12502: [NGRAPH] MXNet - nGraph initial integration

[GitBox <gi...@apache.org>]

zheng-da commented on a change in pull request #12502: [NGRAPH] MXNet - nGraph initial integration
URL: https://github.com/apache/incubator-mxnet/pull/12502#discussion_r249695336
 
 

 ##########
 File path: include/mxnet/ndarray.h
 ##########
 @@ -779,6 +783,12 @@ class NDArray {
   void UpdateMKLDNNMemDesc();
 #endif
 
+#if MXNET_USE_NGRAPH == 1
+  // create and return tensor_view with this ndarray mem
+  std::shared_ptr<ngraph::runtime::Tensor> &create_tensor(bool is_boolean,
+                                                          bool is_scalar);
 
 Review comment:
   @mbrookhart after some discussion with @szha , we would really prefer to not include ngraph in NDArray because NDArray is a class exposed to C++ users. We consider it's part of our API. Changing API is always a big deal for us. The subgraph API actually provides a way to hide everything inside nGraph. I would like to suggest changing your mxnet bridge so that you don't need to put nGraph stuff in NDArray.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services