You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@continuum.apache.org by ke...@apache.org on 2006/07/17 21:11:28 UTC
svn commit: r422803 - in /maven/continuum/trunk/continuum-webapp/src/main:
java/org/apache/maven/continuum/web/view/BuildCell.java
resources/org/apache/maven/continuum/web/action/ConfigurationAction-validation.xml
Author: kenney
Date: Mon Jul 17 12:11:28 2006
New Revision: 422803
URL: http://svn.apache.org/viewvc?rev=422803&view=rev
Log:
Fix HTML error in BuildCell; rendering of the 'Build' column produced
illegal HTML.
Changed 'requiredstring' to 'required' in ConfigurationAction-validation.xml
because 'requiredstring' doesn't exist but 'required' does, and I believe the
default type is a string anyway.
Modified:
maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/view/BuildCell.java
maven/continuum/trunk/continuum-webapp/src/main/resources/org/apache/maven/continuum/web/action/ConfigurationAction-validation.xml
Modified: maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/view/BuildCell.java
URL: http://svn.apache.org/viewvc/maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/view/BuildCell.java?rev=422803&r1=422802&r2=422803&view=diff
==============================================================================
--- maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/view/BuildCell.java (original)
+++ maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/view/BuildCell.java Mon Jul 17 12:11:28 2006
@@ -73,7 +73,7 @@
String url = UrlHelper.buildUrl( "/buildResult.action", request, response, params );
- result += "<a href=\"" + url + ">" + project.getBuildNumber() + "</a>";
+ result += "<a href=\"" + url + "\">" + project.getBuildNumber() + "</a>";
}
else
{
Modified: maven/continuum/trunk/continuum-webapp/src/main/resources/org/apache/maven/continuum/web/action/ConfigurationAction-validation.xml
URL: http://svn.apache.org/viewvc/maven/continuum/trunk/continuum-webapp/src/main/resources/org/apache/maven/continuum/web/action/ConfigurationAction-validation.xml?rev=422803&r1=422802&r2=422803&view=diff
==============================================================================
--- maven/continuum/trunk/continuum-webapp/src/main/resources/org/apache/maven/continuum/web/action/ConfigurationAction-validation.xml (original)
+++ maven/continuum/trunk/continuum-webapp/src/main/resources/org/apache/maven/continuum/web/action/ConfigurationAction-validation.xml Mon Jul 17 12:11:28 2006
@@ -4,17 +4,17 @@
<validators>
<field name="workingDirectory">
- <field-validator type="requiredstring">
+ <field-validator type="required">
<message key="configuration.missing.workingDirectory"/>
</field-validator>
</field>
<field name="buildOutputDirectory">
- <field-validator type="requiredstring">
+ <field-validator type="required">
<message key="configuration.missing.buildOutputDirectory"/>
</field-validator>
</field>
<field name="baseUrl">
- <field-validator type="requiredstring" short-circuit="true">
+ <field-validator type="required" short-circuit="true">
<message key="configuration.missing.baseUrl"/>
</field-validator>
<field-validator type="url">