You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Khazar Mammadli (Code Review)" <ge...@cloudera.org> on 2021/06/07 18:56:57 UTC
[kudu-CR] Add cmake modules to find oat++ Modify thirdparty scripts to include oat++ Modify kudu CMakeLists.txt to add oat++ and rest subdirectory
Hello Attila Bukor,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/17554
to review the following change.
Change subject: Add cmake_modules to find oat++ Modify thirdparty scripts to include oat++ Modify kudu CMakeLists.txt to add oat++ and rest subdirectory
......................................................................
Add cmake_modules to find oat++
Modify thirdparty scripts to include oat++
Modify kudu CMakeLists.txt to add oat++ and rest subdirectory
Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
---
M CMakeLists.txt
A cmake_modules/FindOatpp.cmake
A cmake_modules/FindOatppSwagger.cmake
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
7 files changed, 303 insertions(+), 161 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/17554/1
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 1
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17554
to look at the new patch set (#14).
Change subject: [rest] add oat++ framework to kudu
......................................................................
[rest] add oat++ framework to kudu
Add oat++ framework with swagger module, which is used in the follow-up commits
to implement an embeddable rest server into the master servers and later on
tablet servers.
Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
---
M CMakeLists.txt
A cmake_modules/FindOatpp.cmake
A cmake_modules/FindOatppSwagger.cmake
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
7 files changed, 152 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/17554/14
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 14
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17554 )
Change subject: [rest] add oat++ framework to kudu
......................................................................
Patch Set 18: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 18
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 28 Jul 2021 09:19:46 +0000
Gerrit-HasComments: No
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17554
to look at the new patch set (#11).
Change subject: [rest] add oat++ framework to kudu
......................................................................
[rest] add oat++ framework to kudu
Add oat++ framework with swagger module, which is used in the follow-up commits
to implement an embeddable rest server into the master servers and later on
tablet servers.
Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
---
M CMakeLists.txt
A cmake_modules/FindOatpp.cmake
A cmake_modules/FindOatppSwagger.cmake
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
7 files changed, 150 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/17554/11
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 11
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17554
to look at the new patch set (#10).
Change subject: [rest] add oat++ framework to kudu
......................................................................
[rest] add oat++ framework to kudu
Add oat++ framework with swagger module, which is used in the follow-up commits
to implement an embeddable rest server into the master servers and later on
tablet servers.
Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
---
M CMakeLists.txt
A cmake_modules/FindOatpp.cmake
A cmake_modules/FindOatppSwagger.cmake
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
7 files changed, 151 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/17554/10
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 10
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17554
to look at the new patch set (#13).
Change subject: [rest] add oat++ framework to kudu
......................................................................
[rest] add oat++ framework to kudu
Add oat++ framework with swagger module, which is used in the follow-up commits
to implement an embeddable rest server into the master servers and later on
tablet servers.
Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
---
M CMakeLists.txt
A cmake_modules/FindOatpp.cmake
A cmake_modules/FindOatppSwagger.cmake
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
7 files changed, 154 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/17554/13
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 13
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17554
to look at the new patch set (#12).
Change subject: [rest] add oat++ framework to kudu
......................................................................
[rest] add oat++ framework to kudu
Add oat++ framework with swagger module, which is used in the follow-up commits
to implement an embeddable rest server into the master servers and later on
tablet servers.
Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
---
M CMakeLists.txt
A cmake_modules/FindOatpp.cmake
A cmake_modules/FindOatppSwagger.cmake
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
7 files changed, 154 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/17554/12
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 12
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17554
to look at the new patch set (#3).
Change subject: [rest] add oat++ framework to kudu
......................................................................
[rest] add oat++ framework to kudu
Add oat++ framework with swagger module, which is used in the follow-up commits
to implement an embeddable rest server into the master servers and later on
tablet servers.
Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
---
M CMakeLists.txt
A cmake_modules/FindOatpp.cmake
A cmake_modules/FindOatppSwagger.cmake
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
7 files changed, 142 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/17554/3
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 3
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17554
to look at the new patch set (#7).
Change subject: [rest] add oat++ framework to kudu
......................................................................
[rest] add oat++ framework to kudu
Add oat++ framework with swagger module, which is used in the follow-up commits
to implement an embeddable rest server into the master servers and later on
tablet servers.
Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
---
M CMakeLists.txt
A cmake_modules/FindOatpp.cmake
A cmake_modules/FindOatppSwagger.cmake
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
7 files changed, 142 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/17554/7
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 7
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17554 )
Change subject: [rest] add oat++ framework to kudu
......................................................................
Patch Set 18: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17554/18//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17554/18//COMMIT_MSG@11
PS18, Line 11: Add patches to remove oat++ version number from directory path.
Thank you for addressing this!
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 18
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 27 Jul 2021 23:44:57 +0000
Gerrit-HasComments: Yes
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17554
to look at the new patch set (#17).
Change subject: [rest] add oat++ framework to kudu
......................................................................
[rest] add oat++ framework to kudu
Add oat++ framework with swagger module, which is used in the follow-up commits
to implement an embeddable rest server into the master servers and later on
tablet servers.
Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
---
M CMakeLists.txt
A cmake_modules/FindOatpp.cmake
A cmake_modules/FindOatppSwagger.cmake
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
7 files changed, 158 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/17554/17
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 17
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17554 )
Change subject: [rest] add oat++ framework to kudu
......................................................................
Patch Set 16:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/17554/16/cmake_modules/FindOatpp.cmake
File cmake_modules/FindOatpp.cmake:
http://gerrit.cloudera.org:8080/#/c/17554/16/cmake_modules/FindOatpp.cmake@24
PS16, Line 24: oatpp-1.2.5
Is there a way to use version-agnostic path here? Using version-specific path might be very inconvenient when the package is updated for a new version in future.
I'd expect these path to point to files placed under $KUDU_ROOT/thirdparty/installed/{common,tsan,uninstrumented}, so no version would be in the path?
http://gerrit.cloudera.org:8080/#/c/17554/16/cmake_modules/FindOatpp.cmake@29
PS16, Line 29: oatpp-1.2.5
ditto
http://gerrit.cloudera.org:8080/#/c/17554/16/cmake_modules/FindOatpp.cmake@31
PS16, Line 31: oatpp-1.2.5/
ditto
http://gerrit.cloudera.org:8080/#/c/17554/16/cmake_modules/FindOatppSwagger.cmake
File cmake_modules/FindOatppSwagger.cmake:
http://gerrit.cloudera.org:8080/#/c/17554/16/cmake_modules/FindOatppSwagger.cmake@24
PS16, Line 24: oatpp-1.2.5
ditto: is it possible to switch to a version-agnostic path here?
http://gerrit.cloudera.org:8080/#/c/17554/16/cmake_modules/FindOatppSwagger.cmake@29
PS16, Line 29: oatpp-1.2.5
ditto
http://gerrit.cloudera.org:8080/#/c/17554/16/cmake_modules/FindOatppSwagger.cmake@31
PS16, Line 31: oatpp-1.2.5
ditto
http://gerrit.cloudera.org:8080/#/c/17554/16/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/17554/16/thirdparty/build-definitions.sh@1101
PS16, Line 1101: cmake \
: -DCMAKE_BUILD_TYPE=release \
: -DCMAKE_INSTALL_PREFIX=$PREFIX \
: -DBUILD_SHARED_LIBS=OFF \
: -DOATPP_DISABLE_ENV_OBJECT_COUNTERS=ON \
: -DOATPP_BUILD_TESTS=OFF \
: $OATPP_SOURCE
style nit: for line continuations, add an extra indent (see other build_xxx() functions in this file for reference)
http://gerrit.cloudera.org:8080/#/c/17554/16/thirdparty/build-definitions.sh@1117
PS16, Line 1117: cmake \
: -DCMAKE_BUILD_TYPE=release \
: -DCMAKE_INSTALL_PREFIX=$PREFIX \
: -DBUILD_SHARED_LIBS=OFF \
: -DOATPP_BUILD_TESTS=OFF \
: -DOATPP_INSTALL=ON \
: $OATPP_SWAGGER_SOURCE
ditto
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 16
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 26 Jun 2021 00:20:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17554
to look at the new patch set (#16).
Change subject: [rest] add oat++ framework to kudu
......................................................................
[rest] add oat++ framework to kudu
Add oat++ framework with swagger module, which is used in the follow-up commits
to implement an embeddable rest server into the master servers and later on
tablet servers.
Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
---
M CMakeLists.txt
A cmake_modules/FindOatpp.cmake
A cmake_modules/FindOatppSwagger.cmake
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
7 files changed, 158 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/17554/16
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 16
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17554 )
Change subject: [rest] add oat++ framework to kudu
......................................................................
Patch Set 17: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17554/16/cmake_modules/FindOatpp.cmake
File cmake_modules/FindOatpp.cmake:
http://gerrit.cloudera.org:8080/#/c/17554/16/cmake_modules/FindOatpp.cmake@24
PS16, Line 24: oatpp-1.2.5
> It is possible but I have to change the CmakeLists.txt for the Oat++ and th
I guess a better approach would be adding a patch into $KUDU_HOME/thirdparty/patches to update oatpp-<version>/cmake/module-config.cmake.in and oatpp-<version>/cmake/module-install.cmake once the oatpp is unpacked. The patch would remove the version-specific suffixes for oatpp. The idea is to keep all distro tarballs for Kudu's thirdparty as close to the originals as possible, otherwise the sacred knowledge of making the distro tarballs should be recorded elsewhere.
Overall, it's surprising to me to see oatpp using version-specific paths to install its header and library files. Maybe, that's designed to be used in oatpp development environments where multiple versions of the library installed simultaneously?
If it's more convenient to have those version-related updates for oatpp in a separate follow-up changelist, that's totally fine with me to keep this changelist as-is in this regard and address the version-related issue later on.
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 17
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 06 Jul 2021 16:57:54 +0000
Gerrit-HasComments: Yes
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17554
to look at the new patch set (#5).
Change subject: [rest] add oat++ framework to kudu
......................................................................
[rest] add oat++ framework to kudu
Add oat++ framework with swagger module, which is used in the follow-up commits
to implement an embeddable rest server into the master servers and later on
tablet servers.
Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
---
M CMakeLists.txt
A cmake_modules/FindOatpp.cmake
A cmake_modules/FindOatppSwagger.cmake
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
7 files changed, 141 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/17554/5
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 5
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17554
to look at the new patch set (#2).
Change subject: [rest] add oat++ framework to kudu
......................................................................
[rest] add oat++ framework to kudu
Add two cmake_modules to find Oat++ and Oat++ Swagger.
Modify kudu/CmakeLists.txt to add Oat++ and Oat++ Swagger as static libraries.
Modify thirdparty scripts to add Oat++.
Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
---
M CMakeLists.txt
A cmake_modules/FindOatpp.cmake
A cmake_modules/FindOatppSwagger.cmake
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
7 files changed, 303 insertions(+), 161 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/17554/2
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 2
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17554
to look at the new patch set (#8).
Change subject: [rest] add oat++ framework to kudu
......................................................................
[rest] add oat++ framework to kudu
Add oat++ framework with swagger module, which is used in the follow-up commits
to implement an embeddable rest server into the master servers and later on
tablet servers.
Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
---
M CMakeLists.txt
A cmake_modules/FindOatpp.cmake
A cmake_modules/FindOatppSwagger.cmake
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
7 files changed, 142 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/17554/8
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 8
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17554
to look at the new patch set (#6).
Change subject: [rest] add oat++ framework to kudu
......................................................................
[rest] add oat++ framework to kudu
Add oat++ framework with swagger module, which is used in the follow-up commits
to implement an embeddable rest server into the master servers and later on
tablet servers.
Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
---
M CMakeLists.txt
A cmake_modules/FindOatpp.cmake
A cmake_modules/FindOatppSwagger.cmake
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
7 files changed, 143 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/17554/6
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 6
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Khazar Mammadli has posted comments on this change. ( http://gerrit.cloudera.org:8080/17554 )
Change subject: [rest] add oat++ framework to kudu
......................................................................
Patch Set 16:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17554/16/cmake_modules/FindOatpp.cmake
File cmake_modules/FindOatpp.cmake:
http://gerrit.cloudera.org:8080/#/c/17554/16/cmake_modules/FindOatpp.cmake@24
PS16, Line 24: oatpp-1.2.5
> Is there a way to use version-agnostic path here? Using version-specific p
It is possible but I have to change the CmakeLists.txt for the Oat++ and the Swagger and reupload them to the S3
http://gerrit.cloudera.org:8080/#/c/17554/16/cmake_modules/FindOatppSwagger.cmake
File cmake_modules/FindOatppSwagger.cmake:
http://gerrit.cloudera.org:8080/#/c/17554/16/cmake_modules/FindOatppSwagger.cmake@24
PS16, Line 24: oatpp-1.2.5
> ditto: is it possible to switch to a version-agnostic path here?
It is possible, but I have to change the CmakeLists.txt for the Oat++ Swagger and reupload it to the S3
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 16
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 01 Jul 2021 15:24:32 +0000
Gerrit-HasComments: Yes
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17554 )
Change subject: [rest] add oat++ framework to kudu
......................................................................
Patch Set 14: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 14
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 24 Jun 2021 19:22:49 +0000
Gerrit-HasComments: No
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17554
to look at the new patch set (#4).
Change subject: [rest] add oat++ framework to kudu
......................................................................
[rest] add oat++ framework to kudu
Add oat++ framework with swagger module, which is used in the follow-up commits
to implement an embeddable rest server into the master servers and later on
tablet servers.
Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
---
M CMakeLists.txt
A cmake_modules/FindOatpp.cmake
A cmake_modules/FindOatppSwagger.cmake
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
7 files changed, 141 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/17554/4
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 4
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17554 )
Change subject: [rest] add oat++ framework to kudu
......................................................................
[rest] add oat++ framework to kudu
Add oat++ framework with swagger module, which is used in the follow-up commits
to implement an embeddable rest server into the master servers and later on
tablet servers. Add patches to remove oat++ version number from directory path.
Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Reviewed-on: http://gerrit.cloudera.org:8080/17554
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M CMakeLists.txt
A cmake_modules/FindOatpp.cmake
A cmake_modules/FindOatppSwagger.cmake
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
A thirdparty/patches/oatpp-remove-version-from-path.patch
A thirdparty/patches/oatpp-swagger-remove-version-from-path.patch
M thirdparty/vars.sh
9 files changed, 308 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
Attila Bukor: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 19
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17554
to look at the new patch set (#9).
Change subject: [rest] add oat++ framework to kudu
......................................................................
[rest] add oat++ framework to kudu
Add oat++ framework with swagger module, which is used in the follow-up commits
to implement an embeddable rest server into the master servers and later on
tablet servers.
Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
---
M CMakeLists.txt
A cmake_modules/FindOatpp.cmake
A cmake_modules/FindOatppSwagger.cmake
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
7 files changed, 150 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/17554/9
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 9
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17554
to look at the new patch set (#15).
Change subject: [rest] add oat++ framework to kudu
......................................................................
[rest] add oat++ framework to kudu
Add oat++ framework with swagger module, which is used in the follow-up commits
to implement an embeddable rest server into the master servers and later on
tablet servers.
Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
---
M CMakeLists.txt
A cmake_modules/FindOatpp.cmake
A cmake_modules/FindOatppSwagger.cmake
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
7 files changed, 156 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/17554/15
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 15
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17554 )
Change subject: [rest] add oat++ framework to kudu
......................................................................
Patch Set 5:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/17554/5/CMakeLists.txt
File CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/17554/5/CMakeLists.txt@1492
PS5, Line 1492: add_subdirectory(src/kudu/rest)
this should be in alphabetical order
http://gerrit.cloudera.org:8080/#/c/17554/5/cmake_modules/FindOatpp.cmake
File cmake_modules/FindOatpp.cmake:
http://gerrit.cloudera.org:8080/#/c/17554/5/cmake_modules/FindOatpp.cmake@16
PS5, Line 16: # under the License.
nit: add an extra newline to separate the license portion from the content
http://gerrit.cloudera.org:8080/#/c/17554/5/cmake_modules/FindOatppSwagger.cmake
File cmake_modules/FindOatppSwagger.cmake:
http://gerrit.cloudera.org:8080/#/c/17554/5/cmake_modules/FindOatppSwagger.cmake@16
PS5, Line 16: # under the License.
same as in the other cmake file
http://gerrit.cloudera.org:8080/#/c/17554/5/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/17554/5/thirdparty/build-definitions.sh@1116
PS5, Line 1116: make -j$PARALLEL install
nit: indent
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 5
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 10 Jun 2021 12:07:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has removed a vote on this change.
Change subject: [rest] add oat++ framework to kudu
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 14
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [rest] add oat++ framework to kudu
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17554
to look at the new patch set (#18).
Change subject: [rest] add oat++ framework to kudu
......................................................................
[rest] add oat++ framework to kudu
Add oat++ framework with swagger module, which is used in the follow-up commits
to implement an embeddable rest server into the master servers and later on
tablet servers. Add patches to remove oat++ version number from directory path.
Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
---
M CMakeLists.txt
A cmake_modules/FindOatpp.cmake
A cmake_modules/FindOatppSwagger.cmake
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
A thirdparty/patches/oatpp-remove-version-from-path.patch
A thirdparty/patches/oatpp-swagger-remove-version-from-path.patch
M thirdparty/vars.sh
9 files changed, 308 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/17554/18
--
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 18
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)