[PR] fix(substrait): Allow scalar subquery in projection [datafusion]

["bvolpato-dd (via GitHub)" <gi...@apache.org>]

bvolpato-dd opened a new pull request, #18067:
URL: https://github.com/apache/datafusion/pull/18067

   ## Which issue does this PR close?
   
   - Closes https://github.com/apache/datafusion/issues/18066.
   
   ## Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   Recent validations added at https://github.com/apache/datafusion/pull/15334 started to cause problems for some LEFT JOIN queries that don't have conditions, for example:
   
   ```sql
   SELECT a, (SELECT MAX(b) FROM data2) as max_b FROM data
   ``` 
   
   This query gets optimized as a left join without conditions.
   
   This basically follows the same approach from https://github.com/apache/datafusion/pull/15334 :
   
   https://github.com/apache/datafusion/blob/a65a2cbd6070b392ff7ed5ccd2aa0accaf42177a/datafusion/optimizer/src/scalar_subquery_to_join.rs#L345
   
   
   ## What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   For joins without conditions, use cross_join if inner, otherwise use a filter with `Boolean(true)`
   
   
   
   
   ## Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   Added a roundtrip test case.
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   n/a
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] fix(substrait): Allow scalar subquery in projection [datafusion]

["bvolpato-dd (via GitHub)" <gi...@apache.org>]

bvolpato-dd closed pull request #18067: fix(substrait): Allow scalar subquery in projection
URL: https://github.com/apache/datafusion/pull/18067


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] fix(substrait): Allow scalar subquery in projection [datafusion]

["bvolpato-dd (via GitHub)" <gi...@apache.org>]

bvolpato-dd commented on PR #18067:
URL: https://github.com/apache/datafusion/pull/18067#issuecomment-3404467141

   Sorry for the mess, opened with a different account by mistake.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org