[GitHub] [iceberg] rdblue commented on a change in pull request #3861: Spark: Reduce unnecessary remote service requests in `SparkSessionCatalog.invalidateTable`

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #3861:
URL: https://github.com/apache/iceberg/pull/3861#discussion_r780840785



##########
File path: spark/v3.0/spark/src/main/java/org/apache/iceberg/spark/SparkSessionCatalog.java
##########
@@ -123,11 +123,10 @@ public Table loadTable(Identifier ident) throws NoSuchTableException {
 
   @Override
   public void invalidateTable(Identifier ident) {
-    if (icebergCatalog.tableExists(ident)) {
-      icebergCatalog.invalidateTable(ident);
-    } else {
-      getSessionCatalog().invalidateTable(ident);
-    }
+    // We do not need to check whether the table exists and whether
+    // it is an Iceberg table to reduce remote service requests.
+    icebergCatalog.invalidateTable(ident);

Review comment:
       What about updating `invalidateTable` to return `true` if a table was removed from the cache? Then we could use that to avoid calling `getSessionCatalog().invalidateTable(ident)` at least when there was a table loaded.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org