[GitHub] [datasketches-cpp] will-lauer commented on a diff in pull request #318: Common version

[GitBox <gi...@apache.org>]

will-lauer commented on code in PR #318:
URL: https://github.com/apache/datasketches-cpp/pull/318#discussion_r1015731454


##########
.gitignore:
##########
@@ -1,3 +1,7 @@
+# output of configured files
+version.cfg
+common/include/version.hpp

Review Comment:
   generally, I wouldn't suggest creating the version.hpp file in the common/include directory, but rather in the build directory.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org