You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2017/12/04 13:17:17 UTC
Re: Review Request 63555: Publish resource provider resources before
container launch or update.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63555/#review192693
-----------------------------------------------------------
There exists a race between task launches and speculation failures in a provider of resources (RP or agent itself). To remove the race between the agent's `UpdateSlaveMessage` and master's `RunTaskMessage`/`RunTaskGroupMessage` we will add resource versions to the master's messages and have the agent reject launches if the versions of used resource providers became incompatible, see https://issues.apache.org/jira/browse/MESOS-8222.
I believe there is a similar race between resource providers' `UPDATE_STATE` calls and agents' `PUBLISH` events, so we should inject versions there as well and have resource providers reject `PUBLISH` events in case of incompatibility.
- Benjamin Bannier
On Nov. 4, 2017, 2:55 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63555/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2017, 2:55 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-7550
> https://issues.apache.org/jira/browse/MESOS-7550
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `Slave::publishAllocatedResources()` will compute the total allocated
> resources for all currently running executor containers, and takes an
> `extra` argument for resources that will be used by the executor that
> is about to launch, then sums them up and asks the resource provider
> manager to publish the resources.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7
> src/slave/slave.cpp 337083dbe60bba2d3773b785bdceeaf0b8fcd070
>
>
> Diff: https://reviews.apache.org/r/63555/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>