You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "starocean999 (via GitHub)" <gi...@apache.org> on 2023/12/28 09:58:05 UTC

[PR] [enhancement](nereids)throw readable exception when meet missing column in agg's output [doris]

starocean999 opened a new pull request, #29243:
URL: https://github.com/apache/doris/pull/29243

   
   
   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](nereids)throw readable exception when meet missing column in agg's output [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29243:
URL: https://github.com/apache/doris/pull/29243#issuecomment-1871073109

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 47.25 seconds
    stream load tsv:          562 seconds loaded 74807831229 Bytes, about 126 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          66 seconds loaded 1101869774 Bytes, about 15 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.6 seconds inserted 10000000 Rows, about 349K ops/s
    storage size: 17183589362 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](nereids)throw readable exception when meet missing column in agg's output [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29243:
URL: https://github.com/apache/doris/pull/29243#issuecomment-1873687413

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 46.64 seconds
    stream load tsv:          577 seconds loaded 74807831229 Bytes, about 123 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          66 seconds loaded 1101869774 Bytes, about 15 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.3 seconds inserted 10000000 Rows, about 353K ops/s
    storage size: 17183708747 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](nereids)throw readable exception when meet missing column in agg's output [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29243:
URL: https://github.com/apache/doris/pull/29243#issuecomment-1873687615

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools
   ```
   Tpch sf100 test result on commit 5fcd0ef32833343808842ba4743ce55beb1eb51d, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	5470	5132	5106	5106
   q2	395	159	158	158
   q3	1490	1241	1137	1137
   q4	1105	872	799	799
   q5	3140	3195	3073	3073
   q6	235	136	130	130
   q7	982	551	513	513
   q8	2159	2211	2171	2171
   q9	6695	6691	6624	6624
   q10	3202	3166	3197	3166
   q11	343	227	227	227
   q12	377	230	230	230
   q13	4384	3678	3643	3643
   q14	246	221	220	220
   q15	600	557	551	551
   q16	460	415	404	404
   q17	1045	549	515	515
   q18	7076	6800	7014	6800
   q19	1657	1542	1501	1501
   q20	616	356	361	356
   q21	2881	2499	2465	2465
   q22	400	329	331	329
   Total cold run time: 44958 ms
   Total hot run time: 40118 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	5051	5046	5031	5031
   q2	331	243	256	243
   q3	3379	3312	3278	3278
   q4	2132	2022	2000	2000
   q5	5974	5941	5916	5916
   q6	225	127	121	121
   q7	2417	1925	1894	1894
   q8	3539	3668	3671	3668
   q9	9046	9018	8952	8952
   q10	3858	3923	3903	3903
   q11	579	494	464	464
   q12	814	663	685	663
   q13	3875	3207	3239	3207
   q14	291	283	270	270
   q15	606	543	542	542
   q16	561	503	518	503
   q17	2023	1829	1797	1797
   q18	8718	8356	8881	8356
   q19	1739	1695	1724	1695
   q20	2291	1998	1985	1985
   q21	5701	5371	5370	5370
   q22	559	492	494	492
   Total cold run time: 63709 ms
   Total hot run time: 60350 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](nereids)throw readable exception when meet missing column in agg's output [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29243:
URL: https://github.com/apache/doris/pull/29243#issuecomment-1871077798

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Tpch sf100 test result on commit ddf08846a707ed71e8baaf81b9d8c9a779f5c8e4, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4992	4612	4638	4612
   q2	357	161	156	156
   q3	1466	1299	1202	1202
   q4	1133	955	905	905
   q5	3161	3154	3165	3154
   q6	250	125	126	125
   q7	1024	487	486	486
   q8	2280	2254	2252	2252
   q9	6706	6693	6694	6693
   q10	3190	3260	3253	3253
   q11	319	204	207	204
   q12	350	203	200	200
   q13	4170	3448	3430	3430
   q14	240	208	218	208
   q15	561	514	525	514
   q16	443	382	382	382
   q17	1047	775	596	596
   q18	6999	6734	6872	6734
   q19	1628	1644	1643	1643
   q20	762	298	342	298
   q21	3204	2696	2654	2654
   q22	388	315	305	305
   Total cold run time: 44670 ms
   Total hot run time: 40006 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4574	4553	4557	4553
   q2	272	172	174	172
   q3	3375	3370	3347	3347
   q4	2216	2196	2201	2196
   q5	5728	5706	5717	5706
   q6	238	121	118	118
   q7	2363	1834	1868	1834
   q8	3614	3610	3588	3588
   q9	8991	8967	8925	8925
   q10	3780	3895	3879	3879
   q11	478	358	358	358
   q12	765	597	595	595
   q13	3893	3172	3193	3172
   q14	283	250	267	250
   q15	576	520	513	513
   q16	495	456	485	456
   q17	1994	1956	1958	1956
   q18	8611	8062	8252	8062
   q19	1763	1765	1747	1747
   q20	2259	1947	1913	1913
   q21	6111	5763	5760	5760
   q22	564	474	471	471
   Total cold run time: 62943 ms
   Total hot run time: 59571 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](nereids)throw readable exception when meet missing column in agg's output [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29243:
URL: https://github.com/apache/doris/pull/29243#issuecomment-1873685888

   
   TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools
   ```
   TPC-DS sf100 test result on commit 5fcd0ef32833343808842ba4743ce55beb1eb51d, data reload: false
   
   run tpcds-sf100 query with default conf and session variables
   query1	934	366	352	352
   query2	6411	1912	1943	1912
   query3	6652	212	205	205
   query4	26064	22627	22431	22431
   query5	5612	568	516	516
   query6	282	188	179	179
   query7	4587	270	276	270
   query8	225	210	198	198
   query9	8237	2762	2648	2648
   query10	478	292	242	242
   query11	16088	15563	15450	15450
   query12	139	75	79	75
   query13	1673	325	328	325
   query14	12716	7191	7112	7112
   query15	232	184	189	184
   query16	6498	279	279	279
   query17	1841	513	497	497
   query18	1936	271	284	271
   query19	277	142	138	138
   query20	81	83	81	81
   query21	184	97	95	95
   query22	4805	4827	4781	4781
   query23	32079	31420	31044	31044
   query24	11763	2832	2818	2818
   query25	598	352	350	350
   query26	1712	151	149	149
   query27	2850	287	284	284
   query28	7185	1941	1962	1941
   query29	2083	393	407	393
   query30	290	144	146	144
   query31	958	755	766	755
   query32	89	60	59	59
   query33	723	281	276	276
   query34	892	448	448	448
   query35	909	808	759	759
   query36	1307	1197	1178	1178
   query37	185	72	72	72
   query38	3367	3307	3274	3274
   query39	1349	1285	1286	1285
   query40	282	93	91	91
   query41	37	35	35	35
   query42	103	91	95	91
   query43	541	486	478	478
   query44	1140	714	728	714
   query45	203	193	191	191
   query46	1075	663	654	654
   query47	1673	1586	1558	1558
   query48	358	262	263	262
   query49	1198	329	326	326
   query50	741	326	333	326
   query51	5440	5280	5276	5276
   query52	98	88	91	88
   query53	223	152	150	150
   query54	1383	570	572	570
   query55	91	95	86	86
   query56	215	193	205	193
   query57	1012	946	980	946
   query58	216	210	206	206
   query59	2882	2557	2553	2553
   query60	274	262	244	244
   query61	90	103	85	85
   query62	663	466	489	466
   query63	171	150	155	150
   query64	5877	1811	1705	1705
   query65	3333	3274	3274	3274
   query66	1297	335	346	335
   query67	15754	15737	15710	15710
   query68	12635	546	536	536
   query69	495	248	249	248
   query70	1735	1566	1459	1459
   query71	496	241	224	224
   query72	5583	3573	3636	3573
   query73	2923	317	309	309
   query74	6997	6443	6461	6443
   query75	5090	2263	2300	2263
   query76	6190	1060	1076	1060
   query77	672	270	244	244
   query78	9124	8877	8546	8546
   query79	5057	510	513	510
   query80	703	382	356	356
   query81	477	218	216	216
   query82	239	108	99	99
   query83	161	135	137	135
   query84	246	53	52	52
   query85	933	293	282	282
   query86	402	364	385	364
   query87	3514	3345	3364	3345
   query88	3263	2276	2282	2276
   query89	340	274	259	259
   query90	1848	194	189	189
   query91	123	91	95	91
   query92	63	55	54	54
   query93	2687	516	441	441
   query94	778	189	187	187
   query95	460	430	415	415
   query96	630	323	329	323
   query97	4283	4190	4163	4163
   query98	223	201	191	191
   query99	1091	849	805	805
   Total cold run time: 300122 ms
   Total hot run time: 179891 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](nereids)throw readable exception when meet missing column in agg's output [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #29243:
URL: https://github.com/apache/doris/pull/29243


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](nereids)throw readable exception when meet missing column in agg's output [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29243:
URL: https://github.com/apache/doris/pull/29243#issuecomment-1873662698

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](nereids)throw readable exception when meet missing column in agg's output [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29243:
URL: https://github.com/apache/doris/pull/29243#issuecomment-1873678835

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools
   ```
   Tpch sf100 test result on commit 5fcd0ef32833343808842ba4743ce55beb1eb51d, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17639	5228	5141	5141
   q2	2024	157	143	143
   q3	10613	1099	1148	1099
   q4	10356	807	883	807
   q5	7807	3056	2862	2862
   q6	218	141	134	134
   q7	935	525	554	525
   q8	9285	2095	2073	2073
   q9	6912	6508	6440	6440
   q10	8325	3080	3062	3062
   q11	438	212	217	212
   q12	392	236	236	236
   q13	18000	3617	3620	3617
   q14	241	210	233	210
   q15	585	555	527	527
   q16	454	397	391	391
   q17	987	547	530	530
   q18	7569	6727	6693	6693
   q19	1611	1387	1400	1387
   q20	749	357	347	347
   q21	2838	2403	2492	2403
   q22	397	325	322	322
   Total cold run time: 108375 ms
   Total hot run time: 39161 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	5099	5092	5094	5092
   q2	338	248	245	245
   q3	3337	3288	3261	3261
   q4	2124	1997	1991	1991
   q5	5840	5826	5805	5805
   q6	218	130	128	128
   q7	2356	1957	1898	1898
   q8	3398	3475	3538	3475
   q9	8904	8803	8796	8796
   q10	3824	3887	3897	3887
   q11	600	502	475	475
   q12	790	654	661	654
   q13	7923	3184	3185	3184
   q14	292	275	278	275
   q15	626	539	529	529
   q16	550	494	503	494
   q17	1941	1768	1793	1768
   q18	8665	8401	8276	8276
   q19	1653	1604	1641	1604
   q20	2235	1976	1974	1974
   q21	5670	5242	5301	5242
   q22	528	510	520	510
   Total cold run time: 66911 ms
   Total hot run time: 59563 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](nereids)throw readable exception when meet missing column in agg's output [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29243:
URL: https://github.com/apache/doris/pull/29243#issuecomment-1873662676

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](nereids)throw readable exception when meet missing column in agg's output [doris]

Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #29243:
URL: https://github.com/apache/doris/pull/29243#issuecomment-1871671278

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](nereids)throw readable exception when meet missing column in agg's output [doris]

Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #29243:
URL: https://github.com/apache/doris/pull/29243#issuecomment-1871011112

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](nereids)throw readable exception when meet missing column in agg's output [doris]

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #29243:
URL: https://github.com/apache/doris/pull/29243#issuecomment-1873662336

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org