You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "jeredfloyd (via GitHub)" <gi...@apache.org> on 2026/07/28 13:36:33 UTC
[PR] Resolve OpenSSL 4.0 build issues [trafficserver]
jeredfloyd opened a new pull request, #13440:
URL: https://github.com/apache/trafficserver/pull/13440
Fedora 45 updates to OpenSSL 4.0, which removes several long-deprecated capabilities and breaks ATS build. Specific issues fixed are lack of const tagging of pointers to immutable structures, and disallowed introspection of ASN1_STRING. Resolves #13427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Resolve OpenSSL 4.0 build issues [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #13440:
URL: https://github.com/apache/trafficserver/pull/13440#issuecomment-5137573106
We deal with a similar const-ness difference at another place. `const_cast` is acceptable.
https://github.com/apache/trafficserver/blob/3df2bceb04b4c022aaf5bef67d9986c90fa81fbe/src/iocore/net/OCSPStapling.cc#L370-L371
FYI:
`X509_NAME_get_index_by_NID`:
| Version | Signature |
| ------------------------------ | ------------------------------------------------------------------------------ |
| OpenSSL 1.1.1 | `int X509_NAME_get_index_by_NID(X509_NAME *name, int nid, int lastpos);` |
| OpenSSL 3.0 | `int X509_NAME_get_index_by_NID(const X509_NAME *name, int nid, int lastpos);` |
| OpenSSL master (post-constify) | `int X509_NAME_get_index_by_NID(const X509_NAME *name, int nid, int lastpos);` |
| BoringSSL (current) | `int X509_NAME_get_index_by_NID(const X509_NAME *name, int nid, int lastpos);` |
`X509_get_subject_name`:
| Version | Signature |
| ------------------------------ | -------------------------------------------------------- |
| OpenSSL 1.1.1 | `X509_NAME *X509_get_subject_name(const X509 *a);` |
| OpenSSL 3.0 | `X509_NAME *X509_get_subject_name(const X509 *a);` |
| OpenSSL master (post-constify) | `const X509_NAME *X509_get_subject_name(const X509 *a);` |
| BoringSSL | `X509_NAME *X509_get_subject_name(const X509 *x509);` |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Resolve OpenSSL 4.0 build issues [trafficserver]
Posted by "jeredfloyd (via GitHub)" <gi...@apache.org>.
jeredfloyd commented on PR #13440:
URL: https://github.com/apache/trafficserver/pull/13440#issuecomment-5137340893
Thanks; sorry -- I'll see if I can make time for this tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Resolve OpenSSL 4.0 build issues [trafficserver]
Posted by "jeredfloyd (via GitHub)" <gi...@apache.org>.
jeredfloyd closed pull request #13440: Resolve OpenSSL 4.0 build issues
URL: https://github.com/apache/trafficserver/pull/13440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Resolve OpenSSL 4.0 build issues [trafficserver]
Posted by "jeredfloyd (via GitHub)" <gi...@apache.org>.
jeredfloyd commented on PR #13440:
URL: https://github.com/apache/trafficserver/pull/13440#issuecomment-5194301409
Closing in favor of expanded #13476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Resolve OpenSSL 4.0 build issues [trafficserver]
Posted by "jeredfloyd (via GitHub)" <gi...@apache.org>.
jeredfloyd commented on PR #13440:
URL: https://github.com/apache/trafficserver/pull/13440#issuecomment-5108318379
@JosiahWI oops; done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Resolve OpenSSL 4.0 build issues [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #13440:
URL: https://github.com/apache/trafficserver/pull/13440#issuecomment-5107364569
@jeredfloyd Could you run the `format` CMake target?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Resolve OpenSSL 4.0 build issues [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #13440:
URL: https://github.com/apache/trafficserver/pull/13440#issuecomment-5137603831
> Thanks; sorry -- I'll see if I can make time for this tomorrow.
Thank you for working on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Resolve OpenSSL 4.0 build issues [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #13440:
URL: https://github.com/apache/trafficserver/pull/13440#issuecomment-5106004754
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Resolve OpenSSL 4.0 build issues [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #13440:
URL: https://github.com/apache/trafficserver/pull/13440#issuecomment-5136387622
[approve ci centos debian]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Resolve OpenSSL 4.0 build issues [trafficserver]
Posted by "jeredfloyd (via GitHub)" <gi...@apache.org>.
jeredfloyd commented on PR #13440:
URL: https://github.com/apache/trafficserver/pull/13440#issuecomment-5109759846
Huh. I can't access the trafficserver CI logs; can you tell me what OS versions / OpenSSL versions are in use on the failing CentOS/Debian/FreeBSD/Ubuntu jobs?
I don't see why `decltype` wouldn't work, but I don't work much with C++ so I don't want to proffer a strong opinion here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Resolve OpenSSL 4.0 build issues [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #13440:
URL: https://github.com/apache/trafficserver/pull/13440#issuecomment-5136315101
freebsd and ubuntu both failed for const issues:
```
FAILED: src/tscore/CMakeFiles/tscore.dir/X509HostnameValidator.cc.o
/usr/bin/ccache /usr/lib/llvm-12/bin/clang++ -DDEBUG -DPACKAGE_NAME="\"Apache Traffic Server\"" -DPACKAGE_VERSION=\"11.0.0\" -D_DEBUG -Dlinux -I/home/jenkins/workspace/Github_Builds/ubuntu/src/include -I/home/jenkins/workspace/Github_Builds/ubuntu/src/build/include -I/home/jenkins/workspace/Github_Builds/ubuntu/src/build/src/tscore -I/home/jenkins/workspace/Github_Builds/ubuntu/src/lib/swoc/include -I/home/jenkins/workspace/Github_Builds/ubuntu/src/lib/yamlcpp/include -isystem /home/jenkins/workspace/Github_Builds/ubuntu/src/lib/systemtap -D_FORTIFY_SOURCE=2 -fPIE -fstack-protector -pthread -g -std=c++20 -fPIC -Wthread-safety -Werror=thread-safety -Wno-invalid-offsetof -pipe -Wall -Wextra -Wno-noexcept-type -Wsuggest-override -Wno-vla-extension -fno-strict-aliasing -mcx16 -Werror -MD -MT src/tscore/CMakeFiles/tscore.dir/X509HostnameValidator.cc.o -MF src/tscore/CMakeFiles/tscore.dir/X509HostnameValidator.cc.o.d -o src/tscore/CMakeFiles/tscore.dir/X509HostnameValidator.cc.o -c /hom
e/jenkins/workspace/Github_Builds/ubuntu/src/src/tscore/X509HostnameValidator.cc
../src/tscore/X509HostnameValidator.cc:269:15: error: no matching function for call to 'X509_NAME_get_index_by_NID'
while ((i = X509_NAME_get_index_by_NID(name, NID_commonName, i)) >= 0) {
^~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/openssl/x509.h:810:5: note: candidate function not viable: 1st argument ('const X509_NAME *' (aka 'const X509_name_st *')) would lose const qualifier
int X509_NAME_get_index_by_NID(X509_NAME *name, int nid, int lastpos);
^
1 error generated.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Resolve OpenSSL 4.0 build issues [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #13440:
URL: https://github.com/apache/trafficserver/pull/13440#issuecomment-5108539087
> ../src/tscore/X509HostnameValidator.cc:269:15: error: no matching function for call to 'X509_NAME_get_index_by_NID'
while ((i = X509_NAME_get_index_by_NID(name, NID_commonName, i)) >= 0) {
^~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/openssl/x509.h:810:5: note: candidate function not viable: 1st argument ('const X509_NAME *' (aka 'const X509_name_st *')) would lose const qualifier
int X509_NAME_get_index_by_NID(X509_NAME *name, int nid, int lastpos);
Apparently, not all the X509 APIs in older OpenSSL versions take the name as pointer to const. Would it work to use `auto` or `decltype` to determine the type of the local variable, so that it automatically assumes the correct type for both APIs? (If this approach is used, there should be a comment explaining why this was done.) That's just one idea; I'm interested in how you recommend to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Resolve OpenSSL 4.0 build issues [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #13440:
URL: https://github.com/apache/trafficserver/pull/13440#issuecomment-5118035032
Ubuntu 20.04.6
FreeBSD 13.1
The Debian and CentOS failures were due to GitHub connectivity issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org