[GitHub] [incubator-druid] leventov commented on a change in pull request #7328: EmitterModule: Throw an error on invalid emitter types.

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #7328: EmitterModule: Throw an error on invalid emitter types.
URL: https://github.com/apache/incubator-druid/pull/7328#discussion_r272559397
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/server/emitter/EmitterModule.java
 ##########
 @@ -130,10 +131,10 @@ public void inject(Injector injector)
     {
       final List<Binding<Emitter>> emitterBindings = injector.findBindingsByType(new TypeLiteral<Emitter>(){});
 
-      emitter = findEmitter(emitterType, emitterBindings);
-
-      if (emitter == null) {
+      if (Strings.isNullOrEmpty(emitterType)) {
 
 Review comment:
   @gianm could you please add this reasoning to a comment?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org