[GitHub] [jackrabbit-oak] amit-jain commented on a diff in pull request #745: OAK-9984: FlatFileSplitterTest reliably failing

[GitBox <gi...@apache.org>]

amit-jain commented on code in PR #745:
URL: https://github.com/apache/jackrabbit-oak/pull/745#discussion_r1015322552


##########
oak-run-commons/src/test/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileSplitterTest.java:
##########
@@ -533,4 +548,15 @@ public void uncompress(File src, File dest) throws IOException {
             }
         }
     }
+    
+    private static Set<String> readAllFilesAsSet(List<File> files) {
+        Set<String> set = files.stream().flatMap(file -> {
+            try ( InputStream is = Files.newInputStream(file.toPath())) {

Review Comment:
   > I still see leftover files in TMPDIR, but we can handle that as a less pressing, separate issue.
   
   This should be fixed with my latest commits to
   - Creating TemporaryFolder into the target directory
   - Setting the system property java.tmpdir under the temporary folder



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org