You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/01/04 12:21:09 UTC
Re: Review Request 39804: Windows: Moved `os::find` to its own file,
`stout/os/find.hpp`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39804/
-----------------------------------------------------------
(Updated Jan. 4, 2016, 11:21 a.m.)
Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/Makefile.am a8c35c086ecae21701f6a720f25231c1b0d4e329
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5c1df81193b4b888d2ed5c7dbfa0b5e2fae48467
3rdparty/libprocess/3rdparty/stout/include/stout/os/find.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/39804/diff/
Testing
-------
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
Re: Review Request 39804: Windows: Moved `os::find` to its own file,
`stout/os/find.hpp`.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39804/#review114556
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Jan. 4, 2016, 6:35 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39804/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 6:35 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/Makefile.am b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 14fbca6d222bdfc0e8be301050b4ea1a8a6e7758
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/find.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39804/diff/
>
>
> Testing
> -------
>
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39804: Windows: Moved `os::find` to its own file,
`stout/os/find.hpp`.
Posted by Alex Naparu <al...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39804/#review112620
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Naparu
On Jan. 4, 2016, 6:35 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39804/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 6:35 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/Makefile.am b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 14fbca6d222bdfc0e8be301050b4ea1a8a6e7758
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/find.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39804/diff/
>
>
> Testing
> -------
>
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39804: Windows: Moved `os::find` to its own file,
`stout/os/find.hpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39804/
-----------------------------------------------------------
(Updated Jan. 4, 2016, 6:35 p.m.)
Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/Makefile.am b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 14fbca6d222bdfc0e8be301050b4ea1a8a6e7758
3rdparty/libprocess/3rdparty/stout/include/stout/os/find.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/39804/diff/
Testing
-------
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer