You are viewing a plain text version of this content. The canonical link for it is here.
Posted to slide-dev@jakarta.apache.org by Ritu Kedia <RK...@saba.com> on 2004/08/09 07:48:00 UTC
RE: Patch for Bug# 30317
Davide,
This patch does not seem to have been checked in CVS main line. I would
really appreciate if you could check this in for 2.1.
Regards,
Ritu
-----Original Message-----
From: Ritu Kedia [mailto:RKedia@saba.com]
Sent: Friday, July 30, 2004 6:04 PM
To: 'Slide Developers Mailing List'
Subject: RE: Patch for Bug# 30317
Thanks Davide for this patch. It worked.
Would you be applying this patch to 2.1? Also a similar fix would be
required for other RDBMS stores and File store. It would be great if the
RDBMS store fix would be available in 2.1.
Thanks again,
Regards,
Ritu
-----Original Message-----
From: Davide Savazzi [mailto:davide.savazzi@corefandango.net]
Sent: Thursday, July 29, 2004 5:29 AM
To: Slide Developers Mailing List
Subject: Re: Patch for Bug# 30317
On Wednesday 28 July 2004 14:57, Ritu Kedia wrote:
> I did try the solution proposed by you i.e. count the bytes copied to
> Oracle Blob, but that did not return the correct length. I basically
> executed the select stmt of the storeContent method of the
> OracleRDBMSStore, after the copy method and then retrieved the blob and
> queried for blob.length().
No I mean count the bytes as they are written to Oracle in the copy(...)
method in CommonRDBMSAdapter, so you don't have to write a tmp file.
I think there's a problem in your patch when you use compression and
contentLength is -1.
ziputil.getContentLength() returns the _compressed_ file size, that is good
for:
statement.setBinaryStream(1, is, (int) contentLength);
but bad for:
revisionDescriptor.setContentLength(contentLength);
I've attached patches for Oracle adapter and StoreContentZip, tell me if
they
works to you...
Cheers,
--
Davide Savazzi
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org
Re: Patch for Bug# 30317
Posted by Oliver Zeigermann <ol...@zeigermann.de>.
OK, applied it.
Oliver
Davide Savazzi wrote:
> On Monday 09 August 2004 09:56, Oliver Zeigermann wrote:
>
>
>>No, it's not too late. Attach it, I will commit it.
>
>
> Done. It's the same patch I've sent on 07/28 but updated to the latest version
> of CommonRDBMSAdapter and OracleRDBMSAdapter.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org
Re: Patch for Bug# 30317
Posted by Davide Savazzi <da...@corefandango.net>.
On Monday 09 August 2004 09:56, Oliver Zeigermann wrote:
> No, it's not too late. Attach it, I will commit it.
Done. It's the same patch I've sent on 07/28 but updated to the latest version
of CommonRDBMSAdapter and OracleRDBMSAdapter.
--
Davide Savazzi
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org
Re: Patch for Bug# 30317
Posted by Oliver Zeigermann <ol...@zeigermann.de>.
Davide Savazzi wrote:
> On Monday 09 August 2004 07:48, Ritu Kedia wrote:
>
>>Davide,
>>
>>This patch does not seem to have been checked in CVS main line. I would
>>really appreciate if you could check this in for 2.1.
>
>
> Sorry but I haven't a cvs account yet :) I'll post the patch to bugzilla, if
> someone want to commit it (is it too late?)...
>
> Regards,
No, it's not too late. Attach it, I will commit it.
Besides, this is just the beta. Just no new features, but plenty of time
to fix stuff until the final release.
Oliver
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org
Re: Patch for Bug# 30317
Posted by Davide Savazzi <da...@corefandango.net>.
On Monday 09 August 2004 07:48, Ritu Kedia wrote:
> Davide,
>
> This patch does not seem to have been checked in CVS main line. I would
> really appreciate if you could check this in for 2.1.
Sorry but I haven't a cvs account yet :) I'll post the patch to bugzilla, if
someone want to commit it (is it too late?)...
Regards,
--
Davide Savazzi
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org