You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Remy Maucherat <re...@apache.org> on 2003/02/10 20:49:05 UTC
[4.1.20] Tagging today
Hi,
I plan to tag 4.1.20 later today. Thanks to Glenn and Jan for getting
some good fixes in.
Remy
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: [4.1.20] Tagging today
Posted by Costin Manolache <cm...@yahoo.com>.
Thanks Amy.
Costin
Amy Roh wrote:
>> Amy Roh wrote:
>>
>> > I have investigated further and found out that
>> > GlobalResourcesLifecycleListener is not creating mbeans for
>> > userdatabase anymore, therefore, admin failure due to missing mbeans.
>> >
>> > Costin,
>> > Do you have a better idea why Userdatabase MBeans are not getting
>> > created anymore since your last change? I looked through the code and
>> > it looks like the functionality is still there. I tried reverting back
>> > to 1.3 version and everything works fine.
>>
>> The code is a total mess... If reverting solves the problem - just commit
>> it.
>>
>> All I did is add some instanceof checks - so it'll work with another JNDI
>> implementation. It does work for me - at least with JMX-RI1.2.
>
> I took another look at the change after getting some late lunch and I
> realized NamingEnumeration was skipping an element therefore missing
> userdatabase. I just commited the fix and everything is good now. Food
> always helps. :-)
>
> Amy
>>
>> Do you see any stacktraces ? Or other errors ?
>>
>>
>> costin
>>
>>
>> >
>> > Thanks,
>> > Amy
>> >
>> > Amy Roh wrote:
>> >> I just checked users/groups/roles part of admin because someone filed
>> >> a
>> >> bug and complained about its validation. However, it seems to be
> broken
>> >> not finding MBeans for them due to objectname mismatch? I'm not sure
>> >> what's changed since last release. I'm planning to take a look at it
>> >> further this afternoon.
>> >>
>> >> Thanks,
>> >> Amy
>> >>
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
>> >> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>> >>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: [4.1.20] Tagging today
Posted by Amy Roh <am...@apache.org>.
> Amy Roh wrote:
>
> > I have investigated further and found out that
> > GlobalResourcesLifecycleListener is not creating mbeans for userdatabase
> > anymore, therefore, admin failure due to missing mbeans.
> >
> > Costin,
> > Do you have a better idea why Userdatabase MBeans are not getting
> > created anymore since your last change? I looked through the code and
> > it looks like the functionality is still there. I tried reverting back
> > to 1.3 version and everything works fine.
>
> The code is a total mess... If reverting solves the problem - just commit
> it.
>
> All I did is add some instanceof checks - so it'll work with another JNDI
> implementation. It does work for me - at least with JMX-RI1.2.
I took another look at the change after getting some late lunch and I
realized NamingEnumeration was skipping an element therefore missing
userdatabase. I just commited the fix and everything is good now. Food
always helps. :-)
Amy
>
> Do you see any stacktraces ? Or other errors ?
>
>
> costin
>
>
> >
> > Thanks,
> > Amy
> >
> > Amy Roh wrote:
> >> I just checked users/groups/roles part of admin because someone filed a
> >> bug and complained about its validation. However, it seems to be
broken
> >> not finding MBeans for them due to objectname mismatch? I'm not sure
> >> what's changed since last release. I'm planning to take a look at it
> >> further this afternoon.
> >>
> >> Thanks,
> >> Amy
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> >> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> >>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: [4.1.20] Tagging today
Posted by Costin Manolache <cm...@yahoo.com>.
Amy Roh wrote:
> I have investigated further and found out that
> GlobalResourcesLifecycleListener is not creating mbeans for userdatabase
> anymore, therefore, admin failure due to missing mbeans.
>
> Costin,
> Do you have a better idea why Userdatabase MBeans are not getting
> created anymore since your last change? I looked through the code and
> it looks like the functionality is still there. I tried reverting back
> to 1.3 version and everything works fine.
The code is a total mess... If reverting solves the problem - just commit
it.
All I did is add some instanceof checks - so it'll work with another JNDI
implementation. It does work for me - at least with JMX-RI1.2.
Do you see any stacktraces ? Or other errors ?
costin
>
> Thanks,
> Amy
>
> Amy Roh wrote:
>> I just checked users/groups/roles part of admin because someone filed a
>> bug and complained about its validation. However, it seems to be broken
>> not finding MBeans for them due to objectname mismatch? I'm not sure
>> what's changed since last release. I'm planning to take a look at it
>> further this afternoon.
>>
>> Thanks,
>> Amy
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: [4.1.20] Tagging today
Posted by Amy Roh <am...@sun.com>.
I have investigated further and found out that
GlobalResourcesLifecycleListener is not creating mbeans for userdatabase
anymore, therefore, admin failure due to missing mbeans.
Costin,
Do you have a better idea why Userdatabase MBeans are not getting
created anymore since your last change? I looked through the code and
it looks like the functionality is still there. I tried reverting back
to 1.3 version and everything works fine.
Thanks,
Amy
Amy Roh wrote:
> I just checked users/groups/roles part of admin because someone filed a
> bug and complained about its validation. However, it seems to be broken
> not finding MBeans for them due to objectname mismatch? I'm not sure
> what's changed since last release. I'm planning to take a look at it
> further this afternoon.
>
> Thanks,
> Amy
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: [4.1.20] Tagging today
Posted by Amy Roh <am...@apache.org>.
I just checked users/groups/roles part of admin because someone filed a
bug and complained about its validation. However, it seems to be broken
not finding MBeans for them due to objectname mismatch? I'm not sure
what's changed since last release. I'm planning to take a look at it
further this afternoon.
Thanks,
Amy
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: [4.1.20] Tagging today
Posted by Remy Maucherat <re...@apache.org>.
Costin Manolache wrote:
> After the tag, I would like to port back the jsr77 names for servlets and
> enable the new attributes ( it'll be conditioned by a flag - so it won't be
> enable by default, only if someone sets the flag). The change is local to
> ServerLifecycleListener, and I tested it with reloading and the /admin.
>
> Is it ok ?
We should wait IMO for the next stable release to port that. So if it's
4.1.20, great !
Remy
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: [4.1.20] Tagging today
Posted by Costin Manolache <cm...@yahoo.com>.
jean-frederic clere wrote:
> Remy Maucherat wrote:
>> jean-frederic clere wrote:
>>
>>> Remy Maucherat wrote:
>>>
>>>> Hi,
>>>>
>>>> I plan to tag 4.1.20 later today. Thanks to Glenn and Jan for getting
>>>> some good fixes in.
>>>
>>>
>>>
>>> I would like to add some changes in Manager:
>>> For example to add createEmptySession that fixes some problems related
>>> to SessionId. (The changes I rolled back some weeks ago).
>>> Should I?
>>
>>
>> Yes, you can port that if you want.
>
> Done.
After the tag, I would like to port back the jsr77 names for servlets and
enable the new attributes ( it'll be conditioned by a flag - so it won't be
enable by default, only if someone sets the flag). The change is local to
ServerLifecycleListener, and I tested it with reloading and the /admin.
Is it ok ?
Costin
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: [4.1.20] Tagging today
Posted by Henri Gomez <hg...@apache.org>.
jean-frederic clere wrote:
> Remy Maucherat wrote:
>
>> jean-frederic clere wrote:
>>
>>> Remy Maucherat wrote:
>>>
>>>> Hi,
>>>>
>>>> I plan to tag 4.1.20 later today. Thanks to Glenn and Jan for
>>>> getting some good fixes in.
>>>
>>>
>>>
>>>
>>> I would like to add some changes in Manager:
>>> For example to add createEmptySession that fixes some problems
>>> related to SessionId. (The changes I rolled back some weeks ago).
>>> Should I?
>>
>>
>>
>> Yes, you can port that if you want.
I'll try to make a rpm for it also :)
After my day job of course ;---)
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: [4.1.20] Tagging today
Posted by jean-frederic clere <jf...@fujitsu-siemens.com>.
Remy Maucherat wrote:
> jean-frederic clere wrote:
>
>> Remy Maucherat wrote:
>>
>>> Hi,
>>>
>>> I plan to tag 4.1.20 later today. Thanks to Glenn and Jan for getting
>>> some good fixes in.
>>
>>
>>
>> I would like to add some changes in Manager:
>> For example to add createEmptySession that fixes some problems related
>> to SessionId. (The changes I rolled back some weeks ago).
>> Should I?
>
>
> Yes, you can port that if you want.
Done.
>
> Remy
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: [4.1.20] Tagging today
Posted by Remy Maucherat <re...@apache.org>.
jean-frederic clere wrote:
> Remy Maucherat wrote:
>
>> Hi,
>>
>> I plan to tag 4.1.20 later today. Thanks to Glenn and Jan for getting
>> some good fixes in.
>
>
> I would like to add some changes in Manager:
> For example to add createEmptySession that fixes some problems related
> to SessionId. (The changes I rolled back some weeks ago).
> Should I?
Yes, you can port that if you want.
Remy
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: [4.1.20] Tagging today
Posted by jean-frederic clere <jf...@fujitsu-siemens.com>.
Remy Maucherat wrote:
> Hi,
>
> I plan to tag 4.1.20 later today. Thanks to Glenn and Jan for getting
> some good fixes in.
I would like to add some changes in Manager:
For example to add createEmptySession that fixes some problems related to
SessionId. (The changes I rolled back some weeks ago).
Should I?
>
> Remy
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org