You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/16 01:47:34 UTC
[GitHub] [apisix-dashboard] LiteSun opened a new pull request #477: fix: host should not be required
LiteSun opened a new pull request #477:
URL: https://github.com/apache/apisix-dashboard/pull/477
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
___
### Bugfix
- Description
related issue: #458
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #477: fix: host should not be required
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #477:
URL: https://github.com/apache/apisix-dashboard/pull/477
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #477: fix: host should not be required
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #477:
URL: https://github.com/apache/apisix-dashboard/pull/477#discussion_r489585799
##########
File path: src/pages/Route/components/Step1/RequestConfigView.tsx
##########
@@ -47,7 +47,6 @@ const RequestConfigView: React.FC<Props> = ({ data, disabled, onChange }) => {
<Form.Item
{...(index === 0 ? FORM_ITEM_LAYOUT : FORM_ITEM_WITHOUT_LABEL)}
label={index === 0 ? formatMessage({ id: 'route.request.config.domain.name' }) : ''}
- required
Review comment:
I found that remove `required` here only removed the `*`in the UI,
in order to really remove the required verification of the host form item, the required rules from line 59 to 63 must be removed as well :). @LiteSun @juzhiyuan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #477: fix: host should not be required
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #477:
URL: https://github.com/apache/apisix-dashboard/pull/477#issuecomment-693564981
ping @LiteSun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #477: fix: host should not be required
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #477:
URL: https://github.com/apache/apisix-dashboard/pull/477#discussion_r489881967
##########
File path: src/pages/Route/components/Step1/RequestConfigView.tsx
##########
@@ -47,7 +47,6 @@ const RequestConfigView: React.FC<Props> = ({ data, disabled, onChange }) => {
<Form.Item
{...(index === 0 ? FORM_ITEM_LAYOUT : FORM_ITEM_WITHOUT_LABEL)}
label={index === 0 ? formatMessage({ id: 'route.request.config.domain.name' }) : ''}
- required
Review comment:
DONE by @LiteSun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org