You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Michael Stevens (JIRA)" <ji...@apache.org> on 2011/03/28 17:30:06 UTC
[jira] [Created] (SSHD-115) Missing return handling SFTP
SSH_FXP_OPEN cannot create error
Missing return handling SFTP SSH_FXP_OPEN cannot create error
-------------------------------------------------------------
Key: SSHD-115
URL: https://issues.apache.org/jira/browse/SSHD-115
Project: MINA SSHD
Issue Type: Bug
Affects Versions: 0.5.0
Reporter: Michael Stevens
Stress testing the SFTP Subsystem I found protocol errors when file creation failed. This is due to a missing return after the error status is sent.
The patch is simple...
--- SftpSubsystem.java (revision 1086267)
+++ SftpSubsystem.java (working copy)
@@ -409,6 +409,7 @@
if (((pflags & SSH_FXF_CREAT) != 0)) {
if (!file.isWritable()) {
sendStatus(id, SSH_FX_FAILURE, "Can not create " + path);
+ return;
}
file.create();
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SSHD-115) Missing return handling SFTP
SSH_FXP_OPEN cannot create error
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SSHD-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet resolved SSHD-115.
----------------------------------
Resolution: Fixed
Fix Version/s: 0.6.0
Assignee: Guillaume Nodet
> Missing return handling SFTP SSH_FXP_OPEN cannot create error
> -------------------------------------------------------------
>
> Key: SSHD-115
> URL: https://issues.apache.org/jira/browse/SSHD-115
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 0.5.0
> Reporter: Michael Stevens
> Assignee: Guillaume Nodet
> Fix For: 0.6.0
>
>
> Stress testing the SFTP Subsystem I found protocol errors when file creation failed. This is due to a missing return after the error status is sent.
> The patch is simple...
> --- SftpSubsystem.java (revision 1086267)
> +++ SftpSubsystem.java (working copy)
> @@ -409,6 +409,7 @@
> if (((pflags & SSH_FXF_CREAT) != 0)) {
> if (!file.isWritable()) {
> sendStatus(id, SSH_FX_FAILURE, "Can not create " + path);
> + return;
> }
> file.create();
> }
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira