You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/05/28 14:19:38 UTC
[GitHub] [maven-doxia] michael-o commented on pull request #98: [DOXIA-590] Either provided element class or default class gets ignored
michael-o commented on PR #98:
URL: https://github.com/apache/maven-doxia/pull/98#issuecomment-1140273753
> I don't understand anything, sorry: what is the issue? what does the code change (apart from order in attributes)?
One of the basic problems is that you cannot provide a CSS class attribute from outside because it is overridden so you cannot customize. It is not merged, but simply wiped out. This problem existed now for a very long time, I knew that, but this is the first issue regarding this.
Stupid simple: https://github.com/apache/maven-doxia/blob/c098cc9972b13c761091e66a57261e89195a9271/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java#L1533-L1544
You pass the attribute set, but your potential, custom `CLASS` is dropped in any case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org