[GitHub] [incubator-pinot] bxji commented on a change in pull request #4846: [TE] Refactor the fetch anomalies interface to incorporate detection id within the anomaly slice

[GitBox <gi...@apache.org>]

bxji commented on a change in pull request #4846: [TE] Refactor the fetch anomalies interface to incorporate detection id within the anomaly slice
URL: https://github.com/apache/incubator-pinot/pull/4846#discussion_r349902189
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/spi/model/AnomalySlice.java
 ##########
 @@ -62,28 +83,40 @@ public long getEnd() {
     return end;
   }
 
+  public boolean getIsTaggedAsChild() {
+    return isTaggedAsChild;
+  }
+
   public Multimap<String, String> getFilters() {
     return filters;
   }
 
+  public List<String> getDetectionCompNames() {
 
 Review comment:
   minor nitpick, but is there a reason we are using DetectionCompNames rather than the full DetectionComponentNames?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org