You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Stephan Erb <se...@apache.org> on 2017/02/07 21:32:03 UTC
Review Request 56404: Update PMD to 5.5.3
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56404/
-----------------------------------------------------------
Review request for Aurora and Zameer Manji.
Repository: aurora
Description
-------
Update PMD to 5.5.3 with the for us relevant fixes:
* [java] InvalidSlf4jMessageFormat: False positive with placeholder and exception
* [java] InvalidSlf4jMessageFormat: fails with NPE
Full changelog: https://pmd.github.io/pmd-5.5.3/overview/changelog.html
The increase of the heap size is not really related. However, given the hard to trace
out of memory errors we have seen in some Jenkins builds recently, it is probably
worth a shot.
Diffs
-----
build.gradle 439e0a7444ec4ddb67c983f58b012a5cd0cb33ed
Diff: https://reviews.apache.org/r/56404/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Stephan Erb
Re: Review Request 56404: Update PMD to 5.5.3
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56404/#review164567
-----------------------------------------------------------
Ship it!
Master (cd4df56) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 7, 2017, 9:32 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56404/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 9:32 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Update PMD to 5.5.3 with the for us relevant fixes:
>
> * [java] InvalidSlf4jMessageFormat: False positive with placeholder and exception
> * [java] InvalidSlf4jMessageFormat: fails with NPE
>
> Full changelog: https://pmd.github.io/pmd-5.5.3/overview/changelog.html
>
> The increase of the heap size is not really related. However, given the hard to trace
> out of memory errors we have seen in some Jenkins builds recently, it is probably
> worth a shot.
>
>
> Diffs
> -----
>
> build.gradle 439e0a7444ec4ddb67c983f58b012a5cd0cb33ed
>
> Diff: https://reviews.apache.org/r/56404/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 56404: Update PMD to 5.5.3
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56404/#review164568
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Feb. 7, 2017, 1:32 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56404/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 1:32 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Update PMD to 5.5.3 with the for us relevant fixes:
>
> * [java] InvalidSlf4jMessageFormat: False positive with placeholder and exception
> * [java] InvalidSlf4jMessageFormat: fails with NPE
>
> Full changelog: https://pmd.github.io/pmd-5.5.3/overview/changelog.html
>
> The increase of the heap size is not really related. However, given the hard to trace
> out of memory errors we have seen in some Jenkins builds recently, it is probably
> worth a shot.
>
>
> Diffs
> -----
>
> build.gradle 439e0a7444ec4ddb67c983f58b012a5cd0cb33ed
>
> Diff: https://reviews.apache.org/r/56404/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Stephan Erb
>
>