[GitHub] kasakrisz commented on a change in pull request #25: AMBARI-24833. Extend cloud log rolling options

[GitBox <gi...@apache.org>]

kasakrisz commented on a change in pull request #25: AMBARI-24833. Extend cloud log rolling options
URL: https://github.com/apache/ambari-logsearch/pull/25#discussion_r234152011
 
 

 ##########
 File path: ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/output/RolloverConfig.java
 ##########
 @@ -49,12 +49,32 @@
   @LogSearchPropertyDescription(
     name = LogFeederConstants.CLOUD_ROLLOVER_THRESHOLD_TIME_SIZE,
     description = "Rollover cloud log files after the log file size reach this limit",
-    examples = {"1024KB"},
-    defaultValue = "80MB",
+    examples = {"1024"},
+    defaultValue = "80",
     sources = {LogFeederConstants.LOGFEEDER_PROPERTIES_FILE}
   )
-  @Value("${"+ LogFeederConstants.CLOUD_ROLLOVER_THRESHOLD_TIME_SIZE + ":80MB}")
-  private String rolloverSize;
+  @Value("${"+ LogFeederConstants.CLOUD_ROLLOVER_THRESHOLD_TIME_SIZE + ":80}")
+  private Integer rolloverSize;
+
+  @LogSearchPropertyDescription(
+    name = LogFeederConstants.CLOUD_ROLLOVER_MAX_BACKUP_FILES,
+    description = "The number of max backup log files for rolled over logs.",
+    examples = {"50"},
+    defaultValue = "10",
+    sources = {LogFeederConstants.LOGFEEDER_PROPERTIES_FILE}
+  )
+  @Value("${"+ LogFeederConstants.CLOUD_ROLLOVER_MAX_BACKUP_FILES + ":10}")
+  private Integer rolloverMaxBackupFiles;
+
+  @LogSearchPropertyDescription(
+    name = LogFeederConstants.CLOUD_ROLLOVER_THRESHOLD_TIME_SIZE_FORMAT,
+    description = "Rollover cloud log file size format (e.g: KB, MB etc.)",
 
 Review comment:
   Unit or format?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services