You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/16 11:12:44 UTC

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #5752: arch: cxd56xx: Fix critical section in serial transmission

masayuki2009 commented on a change in pull request #5752:
URL: https://github.com/apache/incubator-nuttx/pull/5752#discussion_r827890886



##########
File path: arch/arm/src/cxd56xx/cxd56_serial.c
##########
@@ -1001,9 +1001,13 @@ static void up_txint(FAR struct uart_dev_s *dev, bool enable)
        * interrupts disabled (note this may recurse).
        */
 
+#  ifdef CONFIG_SMP
       spin_unlock_irqrestore(&priv->lock, flags);

Review comment:
       @pkarashchenko 
   I've been testing spresense:wifi_smp and spresense:rndis_smp but I've never seen the corruption.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org