You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by tripodsan <gi...@git.apache.org> on 2016/02/09 23:01:08 UTC
[GitHub] cordova-mobile-spec pull request: CB-10572 Mobilespec tests not wo...
GitHub user tripodsan opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/137
CB-10572 Mobilespec tests not working for OSX
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tripodsan/cordova-mobile-spec CB-10572
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-mobile-spec/pull/137.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #137
----
commit 3e806441113719a4e7b54db07c2d38cc76d12b8a
Author: Tobias Bocanegra <tr...@adobe.com>
Date: 2016-02-09T19:56:20Z
CB-10572 Mobilespec tests not working for OSX
commit 41f1690fd035d663bcc8897fd9aa045fc900adcb
Author: Tobias Bocanegra <tr...@adobe.com>
Date: 2016-02-09T21:49:17Z
CB-10579 WebSQL mobilespec tests don't work on OSX
commit 0e42f2eaf4d637c2e24210d327f256961f69b287
Author: Tobias Bocanegra <tr...@adobe.com>
Date: 2016-02-09T21:50:02Z
trivial: suppress jasmine warning
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-10572 Mobilespec tests not wo...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/137#discussion_r52676901
--- Diff: createmobilespec/createmobilespec.js ---
@@ -498,6 +522,15 @@ function pluginIdToDirName(id) {
////////////////////// install plugins for each platform
function installPlugins() {
var plugins = DEFAULT_PLUGINS;
+
+ // special override for osx
+ if (argv.osx) {
+ if (platforms.length > 1) {
--- End diff --
This will override the plugins for all platforms, which is incorrect behaviour. Perhaps make the logic override plugins when OSX is the *only* specified platform?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-10572 Mobilespec tests not wo...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/137#discussion_r52677657
--- Diff: createmobilespec/createmobilespec.js ---
@@ -498,6 +522,15 @@ function pluginIdToDirName(id) {
////////////////////// install plugins for each platform
function installPlugins() {
var plugins = DEFAULT_PLUGINS;
+
+ // special override for osx
+ if (argv.osx) {
+ if (platforms.length > 1) {
--- End diff --
@tripodsan thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-10572 Mobilespec tests not wo...
Posted by tripodsan <gi...@git.apache.org>.
Github user tripodsan commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/137#discussion_r52687280
--- Diff: cordova-plugin-mobilespec-tests/tests/datauri.tests.js ---
@@ -27,6 +27,7 @@ exports.defineAutoTests = function () {
function onMessage(done, msg) {
if (msg.data == 'foo') {
+ expect('Suppress SPEC HAS NO EXPECTATIONS').toBeDefined();
--- End diff --
it's not my code...I just fixed the warning :-) I think the test has no expectations because it just needs to wait for the async() to finish. Also, I think this warning was fixed in a more modern jasmine version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-10572 Mobilespec tests not wo...
Posted by tripodsan <gi...@git.apache.org>.
Github user tripodsan commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/137#discussion_r52677263
--- Diff: cordova-plugin-mobilespec-tests/tests/datauri.tests.js ---
@@ -27,6 +27,7 @@ exports.defineAutoTests = function () {
function onMessage(done, msg) {
if (msg.data == 'foo') {
+ expect('Suppress SPEC HAS NO EXPECTATIONS').toBeDefined();
--- End diff --
without it, the tests show the "Spec has no Expectation" warnings. this fixes it.
see http://stackoverflow.com/questions/27016235/angular-js-unit-testing-httpbackend-spec-has-no-expectations
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-10572 Mobilespec tests not wo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/137
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-10572 Mobilespec tests not wo...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/137#discussion_r52676734
--- Diff: cordova-plugin-mobilespec-tests/tests/datauri.tests.js ---
@@ -27,6 +27,7 @@ exports.defineAutoTests = function () {
function onMessage(done, msg) {
if (msg.data == 'foo') {
+ expect('Suppress SPEC HAS NO EXPECTATIONS').toBeDefined();
--- End diff --
What does this expect do?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-10572 Mobilespec tests not wo...
Posted by tripodsan <gi...@git.apache.org>.
Github user tripodsan commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/137#discussion_r52677350
--- Diff: createmobilespec/createmobilespec.js ---
@@ -498,6 +522,15 @@ function pluginIdToDirName(id) {
////////////////////// install plugins for each platform
function installPlugins() {
var plugins = DEFAULT_PLUGINS;
+
+ // special override for osx
+ if (argv.osx) {
+ if (platforms.length > 1) {
--- End diff --
ok. I'll change it....
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-10572 Mobilespec tests not wo...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/137#discussion_r52680237
--- Diff: cordova-plugin-mobilespec-tests/tests/datauri.tests.js ---
@@ -27,6 +27,7 @@ exports.defineAutoTests = function () {
function onMessage(done, msg) {
if (msg.data == 'foo') {
+ expect('Suppress SPEC HAS NO EXPECTATIONS').toBeDefined();
--- End diff --
Why don't the tests themselves have any `expect`s? Also, there are two identical `describe`s in this file. Is that expected?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org