You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/19 23:18:33 UTC
[GitHub] [superset] junlincc opened a new issue #16363: [Time-series table]make chart sort edit sticky and carry sort order to dashboard
junlincc opened a new issue #16363:
URL: https://github.com/apache/superset/issues/16363
I currently can click the sort icons to sort columns value alphabetically or numerically in the time-series table. The problems are
1) the sort result is not sticky on refresh
2) sort result is not being carried to the dashboard
short term solution is to make them sticky
long term is to add sort-by metric control to the time-series table
We should get to both done in one PR or separately.
https://user-images.githubusercontent.com/67837651/130152388-ef45b1a9-9ca6-4ad8-b7d9-f991dc13db6d.mov
one more request, can we remove the blue + button for Time-series columns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on issue #16363: [Time-series table]make chart sort edit sticky and carry sort order to dashboard
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on issue #16363:
URL: https://github.com/apache/superset/issues/16363#issuecomment-906902130
> Current sort logic was only frontend sort and will not trigger api to save the sort logic( it's really an Industry practices
> ), which means the sort logic will disappear when refresh the browser. So I suggest add a button(may called save current sort ) near the table title, and through api to save the sort logic. What do you think? @zhaoyongjie @stephenLYZ
It is not necessary to save the front-end sort, but rather the data sort should be saved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on issue #16363: [Time-series table]make chart sort edit sticky and carry sort order to dashboard
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on issue #16363:
URL: https://github.com/apache/superset/issues/16363#issuecomment-906901711
> > Could we do the migration for this chart and resolve this issue?
>
> is it risky? how long will it take?
about a few days
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #16363: [Time-series table]make chart sort edit sticky and carry sort order to dashboard
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16363:
URL: https://github.com/apache/superset/issues/16363#issuecomment-903889629
> Could we do the migration for this chart and resolve this issue?
is it risky? how long will it take?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie edited a comment on issue #16363: [Time-series table]make chart sort edit sticky and carry sort order to dashboard
Posted by GitBox <gi...@apache.org>.
zhaoyongjie edited a comment on issue #16363:
URL: https://github.com/apache/superset/issues/16363#issuecomment-906902130
> Current sort logic was only frontend sort and will not trigger api to save the sort logic( it's really an Industry practices
> ), which means the sort logic will disappear when refresh the browser. So I suggest add a button(may called save current sort ) near the table title, and through api to save the sort logic. What do you think? @zhaoyongjie @stephenLYZ
It is not necessary to save the front-end sort, but rather the data sort should be saved(ensures data consistency when raw data is changed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] MaxHuiYYDS commented on issue #16363: [Time-series table]make chart sort edit sticky and carry sort order to dashboard
Posted by GitBox <gi...@apache.org>.
MaxHuiYYDS commented on issue #16363:
URL: https://github.com/apache/superset/issues/16363#issuecomment-906895801
Current sort logic was only frontend sort and will not trigger api to save the sort logic( it's really an Industry practices
), which means the sort logic will disappear when refresh the browser. So I suggest add a button(may called save current sort ) near the table title, and through api to save the sort logic. What do you think? @zhaoyongjie @stephenLYZ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie edited a comment on issue #16363: [Time-series table]make chart sort edit sticky and carry sort order to dashboard
Posted by GitBox <gi...@apache.org>.
zhaoyongjie edited a comment on issue #16363:
URL: https://github.com/apache/superset/issues/16363#issuecomment-903509085
Hi @junlincc, “the sort results are not sticky on refresh” exists in all table-like viz. currently, Time-series viz is a legacy chart, and used deprecated API to process the transformation of data. I think that the sorting can be handled in post-processing with the new API(sort operator). Could we do the migration for this chart and resolve this issue?
@villebro What do your think of this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on issue #16363: [Time-series table]make chart sort edit sticky and carry sort order to dashboard
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on issue #16363:
URL: https://github.com/apache/superset/issues/16363#issuecomment-903509085
Hi @junlincc, “the sort results are not sticky on refresh” exists in all table-like viz. currently, Time-series viz is a legacy chart, and used deprecated API to process the transformation of data. I think that the sorting can be handled in post-processing with the new API(sort operator). Could we do the migration for this chart and resolve this issue?
@villebro What do your think about this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] MaxHuiYYDS commented on issue #16363: [Time-series table]make chart sort edit sticky and carry sort order to dashboard
Posted by GitBox <gi...@apache.org>.
MaxHuiYYDS commented on issue #16363:
URL: https://github.com/apache/superset/issues/16363#issuecomment-906904940
> > Current sort logic was only frontend sort and will not trigger api to save the sort logic( it's really an Industry practices
> > ), which means the sort logic will disappear when refresh the browser. So I suggest add a button(may called save current sort ) near the table title, and through api to save the sort logic. What do you think? @zhaoyongjie @stephenLYZ
>
> It is not necessary to save the front-end sort, but rather the data sort should be saved.
Do you mean every frontend sort will trigger an API call? Will it compromise some user experience?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org