You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by hl...@apache.org on 2008/03/04 20:18:53 UTC

svn commit: r633596 - in /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry: corelib/components/BeanEditForm.java services/BeanModelSource.java

Author: hlship
Date: Tue Mar  4 11:18:48 2008
New Revision: 633596

URL: http://svn.apache.org/viewvc?rev=633596&view=rev
Log:
TAPESTRY-2229: BeanEditForm is including properties that are read only, causing errors when the form is submitted

Modified:
    tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/corelib/components/BeanEditForm.java
    tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/services/BeanModelSource.java

Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/corelib/components/BeanEditForm.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/corelib/components/BeanEditForm.java?rev=633596&r1=633595&r2=633596&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/corelib/components/BeanEditForm.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/corelib/components/BeanEditForm.java Tue Mar  4 11:18:48 2008
@@ -123,7 +123,7 @@
         {
             Class beanType = _resources.getBoundType("object");
 
-            _model = _beanModelSource.create(beanType, false, _resources.getContainerResources());
+            _model = _beanModelSource.create(beanType, true, _resources.getContainerResources());
         }
     }
 

Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/services/BeanModelSource.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/services/BeanModelSource.java?rev=633596&r1=633595&r2=633596&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/services/BeanModelSource.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/services/BeanModelSource.java Tue Mar  4 11:18:48 2008
@@ -39,8 +39,10 @@
      *
      * @param beanClass                class of object to be edited
      * @param filterReadOnlyProperties if true, then properties that are read-only will be skipped (leaving only
-     *                                 read-write properties). If false, then both read-only and read-write properties
-     *                                 will be included.
+     *                                 read-write properties, appropriate for {@link org.apache.tapestry.corelib.components.BeanEditForm},
+     *                                 etc.). If false, then both read-only and read-write properties will be included
+     *                                 (appropriate for {@link org.apache.tapestry.corelib.components.Grid} or {@link
+     *                                 org.apache.tapestry.corelib.components.BeanDisplay}).
      * @param resources                used when resolving resources, especially component messages (used to access
      *                                 labels)
      * @return a model