You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/05/06 13:26:46 UTC
[GitHub] [nifi] exceptionfactory opened a new pull request, #6020: NIFI-9995 Replace Custom Filters with Spring Security HeaderWriter
exceptionfactory opened a new pull request, #6020:
URL: https://github.com/apache/nifi/pull/6020
# Summary
[NIFI-9995](https://issues.apache.org/jira/browse/NIFI-9995) Replaces multiple custom Servlet Filters with the Spring Security `HeaderWriterFilter`, configured with Header Writers to apply the same security-related HTTP response headers.
Replacing the custom filters with one filter simplifies Servlet Filter chain processing for HTTP requests and responses while maintaining the same functionality. Making the change in the `StandardRequestFilterProvider` continues to apply the headers to all applicable web applications loaded during NiFi initialization.
The standard configuration matches the current response headers and returns the following:
```
Content-Security-Policy: frame-ancestors 'self'
Strict-Transport-Security: max-age=31536000 ; includeSubDomains
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-XSS-Protection: 1; mode=block
```
The default `HstsHeaderWriter` configuration avoids writing the `Strict-Transport-Security` header for non-HTTPS requests, so the conditional configuration check is no longer necessary.
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0000`
- [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0000`
### Pull Request Formatting
- [X] Pull Request based on current revision of the `main` branch
- [X] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [X] Build completed using `mvn clean install -P contrib-check`
- [X] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #6020: NIFI-9995 Replace Custom Filters with Spring Security HeaderWriter
Posted by GitBox <gi...@apache.org>.
thenatog commented on PR #6020:
URL: https://github.com/apache/nifi/pull/6020#issuecomment-1119746954
Cool, will review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog closed pull request #6020: NIFI-9995 Replace Custom Filters with Spring Security HeaderWriter
Posted by GitBox <gi...@apache.org>.
thenatog closed pull request #6020: NIFI-9995 Replace Custom Filters with Spring Security HeaderWriter
URL: https://github.com/apache/nifi/pull/6020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #6020: NIFI-9995 Replace Custom Filters with Spring Security HeaderWriter
Posted by GitBox <gi...@apache.org>.
thenatog commented on PR #6020:
URL: https://github.com/apache/nifi/pull/6020#issuecomment-1119785190
Yeah this looks good to me, cleans up a few classes and I confirmed that the same headers are still applied to the various web contexts. +1 will merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org