You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/01/06 13:52:35 UTC
[GitHub] [camel] orpiske opened a new pull request #6669: CAMEL-17435: dependency cleanup
orpiske opened a new pull request #6669:
URL: https://github.com/apache/camel/pull/6669
This is the first part of the dependency cleanup. It moves them to the dependency management section so that they are not included by default in all modules.
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a change in pull request #6669: CAMEL-17435: dependency cleanup
Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #6669:
URL: https://github.com/apache/camel/pull/6669#discussion_r780647165
##########
File path: components/camel-microprofile/camel-microprofile-metrics/pom.xml
##########
@@ -47,6 +47,18 @@
<version>${microprofile-metrics-version}</version>
</dependency>
+ <dependency>
+ <groupId>javax.annotation</groupId>
+ <artifactId>javax.annotation-api</artifactId>
+ <version>${javax-annotation-api-version}</version>
+ </dependency>
+
+ <dependency>
Review comment:
What makes MP need JAXB?
##########
File path: components/camel-jmx/pom.xml
##########
@@ -48,6 +48,16 @@
<artifactId>camel-management</artifactId>
</dependency>
+ <dependency>
+ <groupId>jakarta.xml.bind</groupId>
+ <artifactId>jakarta.xml.bind-api</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>com.sun.xml.bind</groupId>
Review comment:
Is there not a jakarta jaxb impl class we can use?
##########
File path: components/camel-spring-xml/pom.xml
##########
@@ -137,6 +137,15 @@
<artifactId>derby</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>javax.annotation</groupId>
+ <artifactId>javax.annotation-api</artifactId>
+ </dependency>
+
+ <dependency>
Review comment:
I wonder what makes saaj-impl needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on a change in pull request #6669: CAMEL-17435: dependency cleanup
Posted by GitBox <gi...@apache.org>.
orpiske commented on a change in pull request #6669:
URL: https://github.com/apache/camel/pull/6669#discussion_r780655070
##########
File path: components/camel-spring-xml/pom.xml
##########
@@ -137,6 +137,15 @@
<artifactId>derby</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>javax.annotation</groupId>
+ <artifactId>javax.annotation-api</artifactId>
+ </dependency>
+
+ <dependency>
Review comment:
I don't remember right now what's requiring it (I think it's a test case).
saaj-impl is also causing problems for Java 17. This version is very outdated.
##########
File path: components/camel-jmx/pom.xml
##########
@@ -48,6 +48,16 @@
<artifactId>camel-management</artifactId>
</dependency>
+ <dependency>
+ <groupId>jakarta.xml.bind</groupId>
+ <artifactId>jakarta.xml.bind-api</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>com.sun.xml.bind</groupId>
Review comment:
I think this one is part of the Jakarta implementation after 2.3.1 (https://eclipse-ee4j.github.io/jaxb-ri/). I am on mobile now, but I will double check later what version we are using. Maybe we have an opportunity to upgrade.
##########
File path: components/camel-jmx/pom.xml
##########
@@ -48,6 +48,16 @@
<artifactId>camel-management</artifactId>
</dependency>
+ <dependency>
+ <groupId>jakarta.xml.bind</groupId>
+ <artifactId>jakarta.xml.bind-api</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>com.sun.xml.bind</groupId>
Review comment:
The link should have been: https://eclipse-ee4j.github.io/jaxb-ri/2.3.3/docs/ch02.html
##########
File path: components/camel-spring-xml/pom.xml
##########
@@ -137,6 +137,15 @@
<artifactId>derby</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>javax.annotation</groupId>
+ <artifactId>javax.annotation-api</artifactId>
+ </dependency>
+
+ <dependency>
Review comment:
Absolutely, I will take a look at this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a change in pull request #6669: CAMEL-17435: dependency cleanup
Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #6669:
URL: https://github.com/apache/camel/pull/6669#discussion_r780039758
##########
File path: core/camel-xml-io/pom.xml
##########
@@ -44,6 +44,11 @@
<groupId>org.apache.camel</groupId>
<artifactId>camel-xml-io-util</artifactId>
</dependency>
+ <dependency>
Review comment:
Argh its maybe overkill to have this JAR because of a generated annotation that bring not much value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on a change in pull request #6669: CAMEL-17435: dependency cleanup
Posted by GitBox <gi...@apache.org>.
orpiske commented on a change in pull request #6669:
URL: https://github.com/apache/camel/pull/6669#discussion_r779827344
##########
File path: components/camel-spring-xml/pom.xml
##########
@@ -137,6 +137,11 @@
<artifactId>derby</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>javax.annotation</groupId>
+ <artifactId>javax.annotation-api</artifactId>
+ <scope>test</scope>
Review comment:
Thanks. I added them in the test scope because it was test code that was failing, but I'll change it to the default one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #6669: CAMEL-17435: dependency cleanup
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #6669:
URL: https://github.com/apache/camel/pull/6669#issuecomment-1007383214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on a change in pull request #6669: CAMEL-17435: dependency cleanup
Posted by GitBox <gi...@apache.org>.
orpiske commented on a change in pull request #6669:
URL: https://github.com/apache/camel/pull/6669#discussion_r780242592
##########
File path: core/camel-xml-io/pom.xml
##########
@@ -44,6 +44,11 @@
<groupId>org.apache.camel</groupId>
<artifactId>camel-xml-io-util</artifactId>
</dependency>
+ <dependency>
Review comment:
FYI: https://github.com/apache/camel/pull/6677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #6669: CAMEL-17435: dependency cleanup
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #6669:
URL: https://github.com/apache/camel/pull/6669#issuecomment-1007383214
BTW: JMX and microprofile still have test failures that I am investigating, which is why it's still marked as a draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a change in pull request #6669: CAMEL-17435: dependency cleanup
Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #6669:
URL: https://github.com/apache/camel/pull/6669#discussion_r780040106
##########
File path: core/camel-api/pom.xml
##########
@@ -54,6 +54,12 @@
<artifactId>slf4j-api</artifactId>
</dependency>
+ <dependency>
Review comment:
Yeah provided would be correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #6669: CAMEL-17435: dependency cleanup
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #6669:
URL: https://github.com/apache/camel/pull/6669#issuecomment-1007475971
> BTW: JMX and microprofile still have test failures that I am investigating, which is why it's still marked as a draft.
These worked locally. Running a new round of full tests to see how it all works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske merged pull request #6669: CAMEL-17435: dependency cleanup
Posted by GitBox <gi...@apache.org>.
orpiske merged pull request #6669:
URL: https://github.com/apache/camel/pull/6669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #6669: CAMEL-17435: dependency cleanup
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #6669:
URL: https://github.com/apache/camel/pull/6669#issuecomment-1006610130
Oh. It also adds a (temp) profile so that unused dependencies can be analyzed more easily with the dependency plugin. To do so:
`mvn -PdependencyReview dependency:analyze`
or
`mvn -PdependencyReview dependency:analyze-report`
If the idea of using the `maven-dependency-plugin` is well received, I think we could move it to the sourceCheck plugin and run it by default ... so that we can catch unused dependencies before they are even added to the code base.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on a change in pull request #6669: CAMEL-17435: dependency cleanup
Posted by GitBox <gi...@apache.org>.
orpiske commented on a change in pull request #6669:
URL: https://github.com/apache/camel/pull/6669#discussion_r779827999
##########
File path: core/camel-api/pom.xml
##########
@@ -54,6 +54,12 @@
<artifactId>slf4j-api</artifactId>
</dependency>
+ <dependency>
Review comment:
Do you mean we could set them to use the `provided` scope?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a change in pull request #6669: CAMEL-17435: dependency cleanup
Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #6669:
URL: https://github.com/apache/camel/pull/6669#discussion_r780655216
##########
File path: components/camel-spring-xml/pom.xml
##########
@@ -137,6 +137,15 @@
<artifactId>derby</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>javax.annotation</groupId>
+ <artifactId>javax.annotation-api</artifactId>
+ </dependency>
+
+ <dependency>
Review comment:
Can you try testing, eg set it to test scope / also try without so we can find out which test, and then add a comment in these testst that they use saaj so we know in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #6669: CAMEL-17435: dependency cleanup
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #6669:
URL: https://github.com/apache/camel/pull/6669#issuecomment-1007678703
I am marking this one as ready for review. I've ran the whole Camel test suite and there were no test failures caused by these dependencies (and only 6 failures in the 22+k tests we have - due to my local environment).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on a change in pull request #6669: CAMEL-17435: dependency cleanup
Posted by GitBox <gi...@apache.org>.
orpiske commented on a change in pull request #6669:
URL: https://github.com/apache/camel/pull/6669#discussion_r780667987
##########
File path: components/camel-spring-xml/pom.xml
##########
@@ -137,6 +137,15 @@
<artifactId>derby</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>javax.annotation</groupId>
+ <artifactId>javax.annotation-api</artifactId>
+ </dependency>
+
+ <dependency>
Review comment:
@davsclaus great catch! So, `saaj-impl` is not needed on the `camel-spring-xml`. It' actually needed by `camel-spring-ws` tests. Marking it as `test` scope seems to be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a change in pull request #6669: CAMEL-17435: dependency cleanup
Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #6669:
URL: https://github.com/apache/camel/pull/6669#discussion_r780647165
##########
File path: components/camel-microprofile/camel-microprofile-metrics/pom.xml
##########
@@ -47,6 +47,18 @@
<version>${microprofile-metrics-version}</version>
</dependency>
+ <dependency>
+ <groupId>javax.annotation</groupId>
+ <artifactId>javax.annotation-api</artifactId>
+ <version>${javax-annotation-api-version}</version>
+ </dependency>
+
+ <dependency>
Review comment:
What makes MP need JAXB?
##########
File path: components/camel-jmx/pom.xml
##########
@@ -48,6 +48,16 @@
<artifactId>camel-management</artifactId>
</dependency>
+ <dependency>
+ <groupId>jakarta.xml.bind</groupId>
+ <artifactId>jakarta.xml.bind-api</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>com.sun.xml.bind</groupId>
Review comment:
Is there not a jakarta jaxb impl class we can use?
##########
File path: components/camel-spring-xml/pom.xml
##########
@@ -137,6 +137,15 @@
<artifactId>derby</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>javax.annotation</groupId>
+ <artifactId>javax.annotation-api</artifactId>
+ </dependency>
+
+ <dependency>
Review comment:
I wonder what makes saaj-impl needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on a change in pull request #6669: CAMEL-17435: dependency cleanup
Posted by GitBox <gi...@apache.org>.
orpiske commented on a change in pull request #6669:
URL: https://github.com/apache/camel/pull/6669#discussion_r780224010
##########
File path: core/camel-xml-io/pom.xml
##########
@@ -44,6 +44,11 @@
<groupId>org.apache.camel</groupId>
<artifactId>camel-xml-io-util</artifactId>
</dependency>
+ <dependency>
Review comment:
Yeah, it seems overkill. Let me take a look and see if I can modify the package plugin to avoid using it. I will send it as a separate PR, so we don't mix things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on a change in pull request #6669: CAMEL-17435: dependency cleanup
Posted by GitBox <gi...@apache.org>.
orpiske commented on a change in pull request #6669:
URL: https://github.com/apache/camel/pull/6669#discussion_r779894156
##########
File path: core/camel-xml-io/pom.xml
##########
@@ -44,6 +44,11 @@
<groupId>org.apache.camel</groupId>
<artifactId>camel-xml-io-util</artifactId>
</dependency>
+ <dependency>
Review comment:
It complains about this:
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project camel-xml-io: Compilation failure: Compilation failure:
[ERROR] /home/opiske/code/java/camel/core/camel-xml-io/src/generated/java/org/apache/camel/xml/in/ModelParser.java:[28,23] error: package javax.annotation does not exist
[ERROR] /home/opiske/code/java/camel/core/camel-xml-io/src/generated/java/org/apache/camel/xml/in/ModelParser.java:[43,1] error: cannot find symbol
[ERROR] symbol: class Generated
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on a change in pull request #6669: CAMEL-17435: dependency cleanup
Posted by GitBox <gi...@apache.org>.
orpiske commented on a change in pull request #6669:
URL: https://github.com/apache/camel/pull/6669#discussion_r780668264
##########
File path: components/camel-microprofile/camel-microprofile-metrics/pom.xml
##########
@@ -47,6 +47,18 @@
<version>${microprofile-metrics-version}</version>
</dependency>
+ <dependency>
+ <groupId>javax.annotation</groupId>
+ <artifactId>javax.annotation-api</artifactId>
+ <version>${javax-annotation-api-version}</version>
+ </dependency>
+
+ <dependency>
Review comment:
Nothing. Will be removed :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a change in pull request #6669: CAMEL-17435: dependency cleanup
Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #6669:
URL: https://github.com/apache/camel/pull/6669#discussion_r779798482
##########
File path: components/camel-spring-xml/pom.xml
##########
@@ -137,6 +137,11 @@
<artifactId>derby</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>javax.annotation</groupId>
+ <artifactId>javax.annotation-api</artifactId>
+ <scope>test</scope>
Review comment:
spring-xml uses JAXB as parser so I would assume the JAXB annotations are required, not test scoped
##########
File path: core/camel-xml-io/pom.xml
##########
@@ -44,6 +44,11 @@
<groupId>org.apache.camel</groupId>
<artifactId>camel-xml-io-util</artifactId>
</dependency>
+ <dependency>
Review comment:
Do you know why camel-xml-io needs those JAXB annotations?
##########
File path: components/camel-spring-xml/pom.xml
##########
@@ -137,6 +137,11 @@
<artifactId>derby</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>javax.annotation</groupId>
+ <artifactId>javax.annotation-api</artifactId>
+ <scope>test</scope>
Review comment:
That is the same for camel-cdi as it also has a XML that is loaded via JAXB.
And so does camel-blueprint in camel-karaf project
##########
File path: core/camel-api/pom.xml
##########
@@ -54,6 +54,12 @@
<artifactId>slf4j-api</artifactId>
</dependency>
+ <dependency>
Review comment:
Since JAXB annotations are only needed when using XML legacy parsing, then I wonder if the scope should be optional.
Another goal for the future is to get rid of JAXB annotations all together - but that is another battle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on a change in pull request #6669: CAMEL-17435: dependency cleanup
Posted by GitBox <gi...@apache.org>.
orpiske commented on a change in pull request #6669:
URL: https://github.com/apache/camel/pull/6669#discussion_r780224010
##########
File path: core/camel-xml-io/pom.xml
##########
@@ -44,6 +44,11 @@
<groupId>org.apache.camel</groupId>
<artifactId>camel-xml-io-util</artifactId>
</dependency>
+ <dependency>
Review comment:
Yeah, it seems overkill. Let me take a look and see if I can modify the package plugin to avoid using it. I will send it as a separate PR, so we don't mix things.
##########
File path: core/camel-xml-io/pom.xml
##########
@@ -44,6 +44,11 @@
<groupId>org.apache.camel</groupId>
<artifactId>camel-xml-io-util</artifactId>
</dependency>
+ <dependency>
Review comment:
FYI: https://github.com/apache/camel/pull/6677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #6669: CAMEL-17435: dependency cleanup
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #6669:
URL: https://github.com/apache/camel/pull/6669#issuecomment-1006690054
This one probably needs a review to make sure I did not miss anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org