[jira] [Comment Edited] (HBASE-17280) Add mechanism to control hbase cleaner behavior

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843517#comment-15843517 ] 

Ted Yu edited comment on HBASE-17280 at 1/27/17 9:30 PM:
---------------------------------------------------------

{code}
+   * @param enable if true enables the cleaner
+   * @return the previous state
+   * @throws MasterNotRunningException
+   */
+  public boolean setCleanerChoreRunning(final boolean on) throws IOException;
{code}
Correct name of parameter in javadoc - on, not enable.
{code}
+                 .setCleanerChoreRunning(getRpcController(), RequestConverter.buildSetCleanerChoreRunningRequest(on))
{code}
Indentation is two spaces per indent. Line length should be no longer than 100
{code}
+  public static RunCleanerChoreRequest buildCleanerChoreRequest() {
+    return CLEANERCHORE_REQUEST;
{code}
The request is to run cleaner. Name the method buildRunCleanerChoreRequest

Name cleaner_enabled.rb cleaner_chore_enabled.rb

Name cleaner_run.rb cleaner_chore_run.rb

Name cleaner_switch.rb cleaner_chore_switch.rb


was (Author: yuzhihong@gmail.com):

+   * @param enable if true enables the cleaner
+   * @return the previous state
+   * @throws MasterNotRunningException
+   */
+  public boolean setCleanerChoreRunning(final boolean on) throws IOException;

Correct name of parameter in javadoc - on, not enable.

+                 .setCleanerChoreRunning(getRpcController(), RequestConverter.buildSetCleanerChoreRunningRequest(on))

Indentation is two spaces per indent. Line length should be no longer than 100

+  public static RunCleanerChoreRequest buildCleanerChoreRequest() {
+    return CLEANERCHORE_REQUEST;

The request is to run cleaner. Name the method buildRunCleanerChoreRequest

Name cleaner_enabled.rb cleaner_chore_enabled.rb

Name cleaner_run.rb cleaner_chore_run.rb

Name cleaner_switch.rb cleaner_chore_switch.rb

> Add mechanism to control hbase cleaner behavior
> -----------------------------------------------
>
>                 Key: HBASE-17280
>                 URL: https://issues.apache.org/jira/browse/HBASE-17280
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client, hbase, shell
>    Affects Versions: 2.0.0, 1.2.0
>            Reporter: Ajay Jadhav
>            Priority: Minor
>             Fix For: 2.0.0, 1.2.0
>
>         Attachments: HBASE-17280.branch-1.2.patch, HBASE-17280.branch-2.0.patch, HBASE-17280.master.003.patch, HBASE-17280.v1-branch-1.2.patch, HBASE-17280.v2-branch-1.2.patch, HBASE-17280.v2-branch-2.patch
>
>
> Cleaner is used to get rid of archived HFiles and old WALs in HBase.
> In the case of heavy workload, cleaner can affect query performance by creating a lot of connections to perform costly reads/ writes against underlying filesystem.
> This patch allows the user to control HBase cleaner behavior by providing shell commands to enable/ disable and manually run it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)