You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by WangTaoTheTonic <gi...@git.apache.org> on 2017/04/17 06:58:52 UTC

[GitHub] flink pull request #3727: [FLINK-6312]update curator version to 2.12.0 to av...

GitHub user WangTaoTheTonic opened a pull request:

    https://github.com/apache/flink/pull/3727

    [FLINK-6312]update curator version to 2.12.0 to avoid potential block

    As there's a Major bug([CURATOR-344](https://issues.apache.org/jira/browse/CURATOR-344)) in curator release used by flink, we need to update the release to 2.12.0 to avoid potential block in flink.
    
     (flink use recipes in checkpoint coordinator and we have already occurred problem in zookeeper failover when we're trying to fix [FLINK-6174](https://issues.apache.org/jira/browse/FLINK-6174))

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/WangTaoTheTonic/flink FLINK-6312

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3727.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3727
    
----
commit 014b042006c0d6b1939e00c68e7d15ce8262400a
Author: WangTaoTheTonic <wa...@huawei.com>
Date:   2017-04-17T06:55:27Z

    update curator version to 2.12.0 to avoid potential block

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3727: [FLINK-6312]update curator version to 2.12.0 to avoid pot...

Posted by WangTaoTheTonic <gi...@git.apache.org>.
Github user WangTaoTheTonic commented on the issue:

    https://github.com/apache/flink/pull/3727
  
    @StephanEwen All tests passed!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3727: [FLINK-6312]update curator version to 2.12.0 to avoid pot...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3727
  
    Has been merged in aadfe45a880d0f71f23c7a742ff5264e8dc14bf8
    
    @WangTaoTheTonic Since the PR was not auto-closed, can you close the PR manually?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3727: [FLINK-6312]update curator version to 2.12.0 to av...

Posted by WangTaoTheTonic <gi...@git.apache.org>.
Github user WangTaoTheTonic closed the pull request at:

    https://github.com/apache/flink/pull/3727


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3727: [FLINK-6312]update curator version to 2.12.0 to avoid pot...

Posted by WangTaoTheTonic <gi...@git.apache.org>.
Github user WangTaoTheTonic commented on the issue:

    https://github.com/apache/flink/pull/3727
  
    Sure. Seems like it will take a little long time but i'll try my best :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3727: [FLINK-6312]update curator version to 2.12.0 to avoid pot...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3727
  
    Thanks a lot, @WangTaoTheTonic !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3727: [FLINK-6312]update curator version to 2.12.0 to avoid pot...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3727
  
    Good idea to upgrade Curator.
    Unfortunately, it seems some behavior in Curator has changed. The change causes many tests to hang/fail:
    
    https://travis-ci.org/apache/flink/builds/222777791
    
    I think this would need to be stabilized before we can merge the fix. Can you look into this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3727: [FLINK-6312]update curator version to 2.12.0 to avoid pot...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3727
  
    Thanks for the fix. Merging this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---