You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by yu...@apache.org on 2026/05/26 02:40:00 UTC
(opendal) 01/01: fix(bindings/go): use ffi.Arg instead of uint8 to avoid segfault
This is an automated email from the ASF dual-hosted git repository.
yuchanns pushed a commit to branch fix/bindings-go-segfault
in repository https://gitbox.apache.org/repos/asf/opendal.git
commit 2d0a51c30b36a4ed7207691ec5d5023dd87fccff
Author: Hanchin Hsieh <me...@yuchanns.xyz>
AuthorDate: Tue May 26 10:39:43 2026 +0800
fix(bindings/go): use ffi.Arg instead of uint8 to avoid segfault
---
bindings/go/metadata.go | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/bindings/go/metadata.go b/bindings/go/metadata.go
index daff59d63..91631ab15 100644
--- a/bindings/go/metadata.go
+++ b/bindings/go/metadata.go
@@ -101,12 +101,12 @@ var ffiMetaIsFile = newFFI(ffiOpts{
aTypes: []*ffi.Type{&ffi.TypePointer},
}, func(ctx context.Context, ffiCall ffiCall) func(m *opendalMetadata) bool {
return func(m *opendalMetadata) bool {
- var result uint8
+ var result ffi.Arg
ffiCall(
unsafe.Pointer(&result),
unsafe.Pointer(&m),
)
- return result == 1
+ return result.Bool()
}
})
@@ -116,12 +116,12 @@ var ffiMetaIsDir = newFFI(ffiOpts{
aTypes: []*ffi.Type{&ffi.TypePointer},
}, func(ctx context.Context, ffiCall ffiCall) func(m *opendalMetadata) bool {
return func(m *opendalMetadata) bool {
- var result uint8
+ var result ffi.Arg
ffiCall(
unsafe.Pointer(&result),
unsafe.Pointer(&m),
)
- return result == 1
+ return result.Bool()
}
})