You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/01 08:45:52 UTC

[GitHub] [flink] dawidwys opened a new pull request #17403: [FLINK-24417] Update MigrationVersion with 1.14 

dawidwys opened a new pull request #17403:
URL: https://github.com/apache/flink/pull/17403


   ## What is the purpose of the change
   
   Update migration tests after releasing 1.14
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] xintongsong commented on pull request #17403: [FLINK-24417] Update MigrationVersion with 1.14

Posted by GitBox <gi...@apache.org>.
xintongsong commented on pull request #17403:
URL: https://github.com/apache/flink/pull/17403#issuecomment-939827994


   FYI, I created FLINK-24502 to track the automation effort.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17403: [FLINK-24417] Update MigrationVersion with 1.14

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17403:
URL: https://github.com/apache/flink/pull/17403#issuecomment-932072806


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4644a1253aca86e625d1cc39e34794458f9e21a3",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24702",
       "triggerID" : "4644a1253aca86e625d1cc39e34794458f9e21a3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4644a1253aca86e625d1cc39e34794458f9e21a3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24702) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] xintongsong commented on pull request #17403: [FLINK-24417] Update MigrationVersion with 1.14

Posted by GitBox <gi...@apache.org>.
xintongsong commented on pull request #17403:
URL: https://github.com/apache/flink/pull/17403#issuecomment-939730322


   The new version is missing from `o.a.f.hdfstests.ContinuousFileProcessingMigrationTest`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dawidwys commented on pull request #17403: [FLINK-24417] Update MigrationVersion with 1.14

Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #17403:
URL: https://github.com/apache/flink/pull/17403#issuecomment-939758290


   I certainly think it is a good idea to try to automate this. Right now, it's really tedious. Moreover in the current form, it must not be part of release managers duty. Theoretically, release managers might not have the required knowledge to regenerate those files, as it requires knowledge of the migration/serialization process and at times a good understanding of what changed (e.g. changed state backends).
   
   However, I also second it should not be part of the PR. As we started working on 1.15 it would be better to just have those changes in for the time being.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dawidwys closed pull request #17403: [FLINK-24417] Update MigrationVersion with 1.14

Posted by GitBox <gi...@apache.org>.
dawidwys closed pull request #17403:
URL: https://github.com/apache/flink/pull/17403


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] xintongsong commented on pull request #17403: [FLINK-24417] Update MigrationVersion with 1.14

Posted by GitBox <gi...@apache.org>.
xintongsong commented on pull request #17403:
URL: https://github.com/apache/flink/pull/17403#issuecomment-939739016


   I wonder if we can make the `MigrationVersion` updates easier, and reduce the chance of making mistakes.
   
   1. Instead of manually going through all places where `MigrationVersion` is used, we may consider something like `MigrationVersion#versionListSince(MigrationVersion sinceVersion)`, so that we won't need to update the list of versions for each relevant test.
   
   2. I wonder if there's a way to simply regeneration of the migration tests files. E.g., a script or maven profile that executes all test cases / methods with a specific annotation.
   
   This for sure can be a separate effort and should not block this PR from merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17403: [FLINK-24417] Update MigrationVersion with 1.14

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17403:
URL: https://github.com/apache/flink/pull/17403#issuecomment-932072806


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4644a1253aca86e625d1cc39e34794458f9e21a3",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24702",
       "triggerID" : "4644a1253aca86e625d1cc39e34794458f9e21a3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4644a1253aca86e625d1cc39e34794458f9e21a3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24702) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17403: [FLINK-24417] Update MigrationVersion with 1.14

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17403:
URL: https://github.com/apache/flink/pull/17403#issuecomment-932072806


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4644a1253aca86e625d1cc39e34794458f9e21a3",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24702",
       "triggerID" : "4644a1253aca86e625d1cc39e34794458f9e21a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fcac54ef9400ce97f10b1a1f190d523311ef9973",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24939",
       "triggerID" : "fcac54ef9400ce97f10b1a1f190d523311ef9973",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4644a1253aca86e625d1cc39e34794458f9e21a3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24702) 
   * fcac54ef9400ce97f10b1a1f190d523311ef9973 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24939) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17403: [FLINK-24417] Update MigrationVersion with 1.14

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17403:
URL: https://github.com/apache/flink/pull/17403#issuecomment-932072806


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4644a1253aca86e625d1cc39e34794458f9e21a3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24702",
       "triggerID" : "4644a1253aca86e625d1cc39e34794458f9e21a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fcac54ef9400ce97f10b1a1f190d523311ef9973",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24939",
       "triggerID" : "fcac54ef9400ce97f10b1a1f190d523311ef9973",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fcac54ef9400ce97f10b1a1f190d523311ef9973 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24939) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17403: [FLINK-24417] Update MigrationVersion with 1.14

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17403:
URL: https://github.com/apache/flink/pull/17403#issuecomment-932042973


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 4644a1253aca86e625d1cc39e34794458f9e21a3 (Fri Oct 01 08:48:38 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17403: [FLINK-24417] Update MigrationVersion with 1.14

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17403:
URL: https://github.com/apache/flink/pull/17403#issuecomment-932072806


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4644a1253aca86e625d1cc39e34794458f9e21a3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4644a1253aca86e625d1cc39e34794458f9e21a3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4644a1253aca86e625d1cc39e34794458f9e21a3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17403: [FLINK-24417] Update MigrationVersion with 1.14

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17403:
URL: https://github.com/apache/flink/pull/17403#issuecomment-932072806


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4644a1253aca86e625d1cc39e34794458f9e21a3",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24702",
       "triggerID" : "4644a1253aca86e625d1cc39e34794458f9e21a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fcac54ef9400ce97f10b1a1f190d523311ef9973",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fcac54ef9400ce97f10b1a1f190d523311ef9973",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4644a1253aca86e625d1cc39e34794458f9e21a3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24702) 
   * fcac54ef9400ce97f10b1a1f190d523311ef9973 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17403: [FLINK-24417] Update MigrationVersion with 1.14

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17403:
URL: https://github.com/apache/flink/pull/17403#issuecomment-932072806


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4644a1253aca86e625d1cc39e34794458f9e21a3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24702",
       "triggerID" : "4644a1253aca86e625d1cc39e34794458f9e21a3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4644a1253aca86e625d1cc39e34794458f9e21a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24702) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org