You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/06/15 12:50:00 UTC
[jira] [Work logged] (WW-5191) template/simple/textarea.ftl not rendering parameters correctly
[ https://issues.apache.org/jira/browse/WW-5191?focusedWorklogId=781627&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-781627 ]
ASF GitHub Bot logged work on WW-5191:
--------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jun/22 12:49
Start Date: 15/Jun/22 12:49
Worklog Time Spent: 10m
Work Description: lukaszlenart opened a new pull request, #572:
URL: https://github.com/apache/struts/pull/572
Fixes [WW-5191](https://issues.apache.org/jira/browse/WW-5191)
Issue Time Tracking
-------------------
Worklog Id: (was: 781627)
Remaining Estimate: 0h
Time Spent: 10m
> template/simple/textarea.ftl not rendering parameters correctly
> ---------------------------------------------------------------
>
> Key: WW-5191
> URL: https://issues.apache.org/jira/browse/WW-5191
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
> Affects Versions: 6.0.0
> Reporter: Burton Rhodes
> Priority: Major
> Fix For: 6.0.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The "simple" textarea.ftl (I haven't checked the other templates) does not have the ending ">" in the correct location. As a result, maxlength and minlength are displayed within the textarea editor.
>
> *Current*
> {code:java}
> <#include "/${parameters.templateDir}/${parameters.expandTheme}/scripting-events.ftl" />
> <#include "/${parameters.templateDir}/${parameters.expandTheme}/common-attributes.ftl" />
> <#include "/${parameters.templateDir}/${parameters.expandTheme}/dynamic-attributes.ftl" />
> ><#rt/> <#-- !! WRONG LOCATION !! -->
> <#if parameters.nameValue??>
> <@s.property value="parameters.nameValue"/><#t/>
> </#if>
> <#if parameters.maxlength?has_content>
> maxlength="${parameters.maxlength}"<#rt/>
> </#if>
> <#if parameters.minlength?has_content>
> minlength="${parameters.minlength}"<#rt/>
> </#if>
> </textarea> {code}
>
> *Should be*
> {code:java}
> <#include "/${parameters.templateDir}/${parameters.expandTheme}/scripting-events.ftl" />
> <#include "/${parameters.templateDir}/${parameters.expandTheme}/common-attributes.ftl" />
> <#include "/${parameters.templateDir}/${parameters.expandTheme}/dynamic-attributes.ftl" />
> <#if parameters.nameValue??>
> <@s.property value="parameters.nameValue"/><#t/>
> </#if>
> <#if parameters.maxlength?has_content>
> maxlength="${parameters.maxlength}"<#rt/>
> </#if>
> <#if parameters.minlength?has_content>
> minlength="${parameters.minlength}"<#rt/>
> </#if>
> ><#rt/> <#-- !! CORRECT LOCATION !! -->
> </textarea>{code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)