You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/08/21 15:25:22 UTC

[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2485: [New-Engine]Support Hdfs Storage and async storage

ashulin commented on code in PR #2485:
URL: https://github.com/apache/incubator-seatunnel/pull/2485#discussion_r950862538


##########
seatunnel-engine/seatunnel-engine-storage/checkpoint-storage-api/src/main/java/org/apache/seatunnel/engine/checkpoint/storage/common/ProtoStuffSerializer.java:
##########
@@ -48,12 +43,13 @@ private static <T> Schema<T> getSchema(Class<T> clazz) {
     @Override
     public <T> byte[] serialize(T obj) {
         Class<T> clazz = (Class<T>) obj.getClass();
+        LinkedBuffer buffer = LinkedBuffer.allocate(LinkedBuffer.DEFAULT_BUFFER_SIZE);

Review Comment:
   I don't quite understand the change here, could you please explain it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org