You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Qifan Chen (Jira)" <ji...@apache.org> on 2020/11/03 16:04:00 UTC

[jira] [Resolved] (IMPALA-4065) Inline comparator calls into TopN::InsertBatch()

     [ https://issues.apache.org/jira/browse/IMPALA-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Qifan Chen resolved IMPALA-4065.
--------------------------------
    Fix Version/s: Impala 4.0
       Resolution: Fixed

> Inline comparator calls into TopN::InsertBatch()
> ------------------------------------------------
>
>                 Key: IMPALA-4065
>                 URL: https://issues.apache.org/jira/browse/IMPALA-4065
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Backend
>    Affects Versions: Impala 2.7.0
>            Reporter: Tim Armstrong
>            Assignee: Qifan Chen
>            Priority: Minor
>              Labels: codegen, ramp-up
>             Fix For: Impala 4.0
>
>         Attachments: 0001-WIP-IMPALA-3816-IMPALA-4065-full-TupleRowComparator-.patch
>
>
> This is the more interesting follow-on from IMPALA-3815. We should inline the Compare() calls in the codegen'd TopN code to avoid the indirect function pointer call.
> The tricky aspect is that the Compare() calls are called from std::priority_queue, and we don't have a way to force-inline those functions at the moment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org