You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/31 00:50:07 UTC

[GitHub] [arrow-datafusion] jychen7 commented on issue #2109: Almost 100x slowdown on 0.7.0 with CSV file

jychen7 commented on issue #2109:
URL: https://github.com/apache/arrow-datafusion/issues/2109#issuecomment-1083882640


   interesting, from the `master` branch as of now, the default `1000` is set in `CsvReadOptions`
   https://github.com/apache/arrow-datafusion/blob/c43b9ab9922ccbaaf6fe6f27e3d31201989edb1e/datafusion/core/src/execution/options.rs#L56-L66
   
   And should be passed when converted to `ListingOptions`, need investigate more
   https://github.com/apache/arrow-datafusion/blob/c43b9ab9922ccbaaf6fe6f27e3d31201989edb1e/datafusion/core/src/execution/options.rs#L106-L114
   
   ---
   
   but I agree we can set default const `1000` and use it across the code base
   https://github.com/apache/arrow-datafusion/blob/c43b9ab9922ccbaaf6fe6f27e3d31201989edb1e/datafusion/core/src/datasource/file_format/csv.rs#L46-L54


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org