You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/02/26 13:04:52 UTC
[GitHub] rabbah commented on a change in pull request #4305: Use runtime
tags specified in runtime manifest for YARNContainerFactoryTests
rabbah commented on a change in pull request #4305: Use runtime tags specified in runtime manifest for YARNContainerFactoryTests
URL: https://github.com/apache/incubator-openwhisk/pull/4305#discussion_r260274011
##########
File path: tests/src/test/scala/org/apache/openwhisk/core/containerpool/yarn/test/YARNContainerFactoryTests.scala
##########
@@ -35,29 +36,18 @@ import scala.concurrent.Await
import scala.concurrent.duration._
@RunWith(classOf[JUnitRunner])
-class YARNContainerFactoryTests extends Suite with BeforeAndAfter with FlatSpecLike {
-
+class YARNContainerFactoryTests extends Suite with BeforeAndAfter with FlatSpecLike with ExecHelpers {
val images = Array(
- ImageName("nodejs6action", Option("openwhisk"), Option("latest")),
- ImageName("python3action", Option("openwhisk"), Option("latest")))
-
- val runtimes: String = "{\"runtimes\":{" +
- "\"nodejs\":[{\"kind\":\"nodejs:6\",\"image\":{\"prefix\":\"openwhisk\",\"name\":\"nodejs6action\",\"tag\":\"latest\"}}]," +
- "\"python\":[{\"kind\":\"python:3\",\"image\":{\"prefix\":\"openwhisk\",\"name\":\"python3action\",\"tag\":\"latest\"}}]" +
- "}}"
-
- implicit val logging: PrintStreamLogging = new PrintStreamLogging()
- implicit val whiskConfig: WhiskConfig = new WhiskConfig(
- Map(wskApiHostname -> "apihost", runtimesManifest -> runtimes) ++ wskApiHost)
-
+ ImageName("nodejs6action", Option("openwhisk"), imageTag("nodejs:6")),
Review comment:
The intent here was to provide a custom manifest to load so that it is decoupled from the actual runtime manifest.
I _think_ that the impression was that if you create a new whisk config object from the given manifest, the config is loaded when in fact it isn't (I should have pointed this out).
I prefer to restore the intended behavior and decouple the test manifest from the deployment manifest. I did this recently in another PR as an example, see here: https://github.com/apache/incubator-openwhisk/pull/4284/files#diff-497ffa2cac9fe692a1df3b53e9793a41R1645
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services