You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/13 21:26:20 UTC

[GitHub] [pulsar] michaeljmarshall opened a new issue, #16584: Add Broker Cache Entry Eviction Rate Metric

michaeljmarshall opened a new issue, #16584:
URL: https://github.com/apache/pulsar/issues/16584

   **Is your enhancement request related to a problem? Please describe.**
   The current broker cache eviction metric, `pulsar_ml_cache_evictions`, measures when the cache's [hasSpaceInCache](
   https://github.com/apache/pulsar/blob/e4092498cc01473a8a67441b082b9d86ed06890d/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/cache/RangeEntryCacheManagerImpl.java#L112-L138) triggers an eviction. There are no other cache eviction metrics right now, making it hard to gain insight into cache evictions.
   
   
   **Describe the solution you'd like**
   I would like to see metrics providing insight into the rate at which entries are getting evicted from the cache. I'm not sure if entry invalidations should also be included in this metric, but we should consider a metric for that as well.
   
   These metrics would only be computed at the broker level.
   
   **Describe alternatives you've considered**
   I don't see another metric that gives insight into broker cache evictions.
   
   **Additional context**
   Add any other context or screenshots about the feature request here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on issue #16584: Add Broker Cache Entry Eviction Rate Metric

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #16584:
URL: https://github.com/apache/pulsar/issues/16584#issuecomment-1225127211

   @tjiuming - sorry, I missed your comment. I implemented the metrics today. Feel free to review the PR if you have time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on issue #16584: Add Broker Cache Entry Eviction Rate Metric

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #16584:
URL: https://github.com/apache/pulsar/issues/16584#issuecomment-1183695208

   @lhotari - I think additional metrics like the one described above could help make an issue like https://github.com/apache/pulsar/issues/16054 easier to observe.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tjiuming commented on issue #16584: Add Broker Cache Entry Eviction Rate Metric

Posted by GitBox <gi...@apache.org>.
tjiuming commented on issue #16584:
URL: https://github.com/apache/pulsar/issues/16584#issuecomment-1206179662

   @michaeljmarshall I'd like to fix the issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall closed issue #16584: Add Broker Cache Entry Eviction Rate Metric

Posted by GitBox <gi...@apache.org>.
michaeljmarshall closed issue #16584: Add Broker Cache Entry Eviction Rate Metric
URL: https://github.com/apache/pulsar/issues/16584


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org