You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@crail.apache.org by asqasq <gi...@git.apache.org> on 2018/09/26 18:08:08 UTC

[GitHub] incubator-crail pull request #40: This commit fixes few minor issues for the...

GitHub user asqasq opened a pull request:

    https://github.com/apache/incubator-crail/pull/40

    This commit fixes few minor issues for the docker build.

    - Read Crail version from toplevel pom.xml
    - Move Crail build directory to /home/crail
    - Point CRAIL_HOME to /home/crail
    - Use template core-site.xml.env file and subsitute environment variables
      to a new core-site.xml file
    
    Close #51
    Close #52
    
    Signed-off-by: Adrian Schuepbach <as...@apache.org>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/asqasq/incubator-crail dockerversion

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-crail/pull/40.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #40
    
----
commit 8253ae2a2bbaeb5674498b202125f3ad92651356
Author: Ubuntu <ub...@...>
Date:   2018-09-26T14:11:34Z

    This commit fixes few minor issues for the docker build.
    
    - Read Crail version from toplevel pom.xml
    - Move Crail build directory to /home/crail
    - Point CRAIL_HOME to /home/crail
    - Use template core-site.xml.env file and subsitute environment variables
      to a new core-site.xml file
    
    Close #51
    Close #52
    
    Signed-off-by: Adrian Schuepbach <as...@apache.org>

----


---

[GitHub] incubator-crail pull request #40: This commit fixes few minor issues for the...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-crail/pull/40


---

[GitHub] incubator-crail issue #40: This commit fixes few minor issues for the docker...

Posted by PepperJo <gi...@git.apache.org>.
Github user PepperJo commented on the issue:

    https://github.com/apache/incubator-crail/pull/40
  
    Can you add links to the JIRA issues in the commit message?
    Looking at the CRAIL_HOME again I think we should just copy it to /crail instead of /home/crail. What do you think?


---

[GitHub] incubator-crail issue #40: This commit fixes few minor issues for the docker...

Posted by asqasq <gi...@git.apache.org>.
Github user asqasq commented on the issue:

    https://github.com/apache/incubator-crail/pull/40
  
    Uploaded the new version with the changes as discussed.


---

[GitHub] incubator-crail issue #40: This commit fixes few minor issues for the docker...

Posted by PepperJo <gi...@git.apache.org>.
Github user PepperJo commented on the issue:

    https://github.com/apache/incubator-crail/pull/40
  
    Great Thx!


---

[GitHub] incubator-crail issue #40: This commit fixes few minor issues for the docker...

Posted by asqasq <gi...@git.apache.org>.
Github user asqasq commented on the issue:

    https://github.com/apache/incubator-crail/pull/40
  
    Sure, I will add the links.
    
    Ok, it is fine with me to copy to /crail instead of /home/crail. I think it does not matter as much, as long as the path is reasonably easy to use and generic (not include the version number).
    
    I will change it to copy to /crail directly.



---