You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Kristian Rosenvold <kr...@gmail.com> on 2014/10/18 20:22:30 UTC

Important Notice for all users of the parallel build feature

Thanks to an excellent testcase provided by a JIRA user, a significant
source of thread safety bugs has been located and fixed. The problem
has an extensive reach, and can be the source of practically *any*
issue in parallel builds, and is probably the root cause of most JIRA
issues filed wrt parallel build problems.

Fortunately, there is a very simple fix by putting the following
inside your plugin configuration:

        <plugin>
          ...
          <dependencies>
            <dependency>
              <groupId>org.codehaus.plexus</groupId>
              <artifactId>plexus-interpolation</artifactId>
              <version>1.21</version>
            </dependency>
          </dependencies>
        </plugin>


You should also put this jar file in the lib/ext folder of your maven
installation:

http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-interpolation/1.21/plexus-interpolation-1.21.jar


Which plugins are affected ? It's almost easier to tell which is /not/
affected. See the "relates" link on
https://jira.codehaus.org/browse/PLXCOMP-258 to see which
plugins/tools are affected.

Kristian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: Important Notice for all users of the parallel build feature

Posted by Kristian Rosenvold <kr...@gmail.com>.
All the components have individual release cycles, so it's probably
going to be a little while before everything is updated.

Kristian


2014-10-18 22:54 GMT+02:00 tibor17 <ti...@lycos.com>:
> Hi Kristian,
> Nice fix.
> There are several plugins using plexus-interpolation like resources,
> dependency, war...
> Would all of these patched maven plugins been planned in the next Maven
> (components and default-bindings) release as well?
>
>
>
> -----
> BR, tibor17
> --
> View this message in context: http://maven.40175.n5.nabble.com/Important-Notice-for-all-users-of-the-parallel-build-feature-tp5809947p5810008.html
> Sent from the Maven Developers mailing list archive at Nabble.com.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: Important Notice for all users of the parallel build feature

Posted by tibor17 <ti...@lycos.com>.
Hi Kristian, 
Nice fix.
There are several plugins using plexus-interpolation like resources,
dependency, war...
Would all of these patched maven plugins been planned in the next Maven
(components and default-bindings) release as well? 



-----
BR, tibor17
--
View this message in context: http://maven.40175.n5.nabble.com/Important-Notice-for-all-users-of-the-parallel-build-feature-tp5809947p5810008.html
Sent from the Maven Developers mailing list archive at Nabble.com.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: Important Notice for all users of the parallel build feature

Posted by Kristian Rosenvold <kr...@gmail.com>.
As can be seen from https://jira.codehaus.org/browse/PLXCOMP-258, all
the related issues are marked as "fixed", which means the fix will be
part of the next release of all the components in question. Given the
number of components involved, this will take a bit of time..

Kristian

2014-10-18 20:42 GMT+02:00 Maxim Solodovnik <so...@gmail.com>:
> Is it possible to include this jar to maven distribution? Because it is not
> always possible to change it on build servers .....
>
> On 19 October 2014 01:22, Kristian Rosenvold <kr...@gmail.com>
> wrote:
>
>> Thanks to an excellent testcase provided by a JIRA user, a significant
>> source of thread safety bugs has been located and fixed. The problem
>> has an extensive reach, and can be the source of practically *any*
>> issue in parallel builds, and is probably the root cause of most JIRA
>> issues filed wrt parallel build problems.
>>
>> Fortunately, there is a very simple fix by putting the following
>> inside your plugin configuration:
>>
>>         <plugin>
>>           ...
>>           <dependencies>
>>             <dependency>
>>               <groupId>org.codehaus.plexus</groupId>
>>               <artifactId>plexus-interpolation</artifactId>
>>               <version>1.21</version>
>>             </dependency>
>>           </dependencies>
>>         </plugin>
>>
>>
>> You should also put this jar file in the lib/ext folder of your maven
>> installation:
>>
>>
>> http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-interpolation/1.21/plexus-interpolation-1.21.jar
>>
>>
>> Which plugins are affected ? It's almost easier to tell which is /not/
>> affected. See the "relates" link on
>> https://jira.codehaus.org/browse/PLXCOMP-258 to see which
>> plugins/tools are affected.
>>
>> Kristian
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
>> For additional commands, e-mail: users-help@maven.apache.org
>>
>>
>
>
> --
> WBR
> Maxim aka solomax

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: Important Notice for all users of the parallel build feature

Posted by Kristian Rosenvold <kr...@gmail.com>.
As can be seen from https://jira.codehaus.org/browse/PLXCOMP-258, all
the related issues are marked as "fixed", which means the fix will be
part of the next release of all the components in question. Given the
number of components involved, this will take a bit of time..

Kristian

2014-10-18 20:42 GMT+02:00 Maxim Solodovnik <so...@gmail.com>:
> Is it possible to include this jar to maven distribution? Because it is not
> always possible to change it on build servers .....
>
> On 19 October 2014 01:22, Kristian Rosenvold <kr...@gmail.com>
> wrote:
>
>> Thanks to an excellent testcase provided by a JIRA user, a significant
>> source of thread safety bugs has been located and fixed. The problem
>> has an extensive reach, and can be the source of practically *any*
>> issue in parallel builds, and is probably the root cause of most JIRA
>> issues filed wrt parallel build problems.
>>
>> Fortunately, there is a very simple fix by putting the following
>> inside your plugin configuration:
>>
>>         <plugin>
>>           ...
>>           <dependencies>
>>             <dependency>
>>               <groupId>org.codehaus.plexus</groupId>
>>               <artifactId>plexus-interpolation</artifactId>
>>               <version>1.21</version>
>>             </dependency>
>>           </dependencies>
>>         </plugin>
>>
>>
>> You should also put this jar file in the lib/ext folder of your maven
>> installation:
>>
>>
>> http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-interpolation/1.21/plexus-interpolation-1.21.jar
>>
>>
>> Which plugins are affected ? It's almost easier to tell which is /not/
>> affected. See the "relates" link on
>> https://jira.codehaus.org/browse/PLXCOMP-258 to see which
>> plugins/tools are affected.
>>
>> Kristian
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
>> For additional commands, e-mail: users-help@maven.apache.org
>>
>>
>
>
> --
> WBR
> Maxim aka solomax

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org


Re: Important Notice for all users of the parallel build feature

Posted by Maxim Solodovnik <so...@gmail.com>.
Is it possible to include this jar to maven distribution? Because it is not
always possible to change it on build servers .....

On 19 October 2014 01:22, Kristian Rosenvold <kr...@gmail.com>
wrote:

> Thanks to an excellent testcase provided by a JIRA user, a significant
> source of thread safety bugs has been located and fixed. The problem
> has an extensive reach, and can be the source of practically *any*
> issue in parallel builds, and is probably the root cause of most JIRA
> issues filed wrt parallel build problems.
>
> Fortunately, there is a very simple fix by putting the following
> inside your plugin configuration:
>
>         <plugin>
>           ...
>           <dependencies>
>             <dependency>
>               <groupId>org.codehaus.plexus</groupId>
>               <artifactId>plexus-interpolation</artifactId>
>               <version>1.21</version>
>             </dependency>
>           </dependencies>
>         </plugin>
>
>
> You should also put this jar file in the lib/ext folder of your maven
> installation:
>
>
> http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-interpolation/1.21/plexus-interpolation-1.21.jar
>
>
> Which plugins are affected ? It's almost easier to tell which is /not/
> affected. See the "relates" link on
> https://jira.codehaus.org/browse/PLXCOMP-258 to see which
> plugins/tools are affected.
>
> Kristian
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> For additional commands, e-mail: users-help@maven.apache.org
>
>


-- 
WBR
Maxim aka solomax

Re: Important Notice for all users of the parallel build feature

Posted by Maxim Solodovnik <so...@gmail.com>.
Is it possible to include this jar to maven distribution? Because it is not
always possible to change it on build servers .....

On 19 October 2014 01:22, Kristian Rosenvold <kr...@gmail.com>
wrote:

> Thanks to an excellent testcase provided by a JIRA user, a significant
> source of thread safety bugs has been located and fixed. The problem
> has an extensive reach, and can be the source of practically *any*
> issue in parallel builds, and is probably the root cause of most JIRA
> issues filed wrt parallel build problems.
>
> Fortunately, there is a very simple fix by putting the following
> inside your plugin configuration:
>
>         <plugin>
>           ...
>           <dependencies>
>             <dependency>
>               <groupId>org.codehaus.plexus</groupId>
>               <artifactId>plexus-interpolation</artifactId>
>               <version>1.21</version>
>             </dependency>
>           </dependencies>
>         </plugin>
>
>
> You should also put this jar file in the lib/ext folder of your maven
> installation:
>
>
> http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-interpolation/1.21/plexus-interpolation-1.21.jar
>
>
> Which plugins are affected ? It's almost easier to tell which is /not/
> affected. See the "relates" link on
> https://jira.codehaus.org/browse/PLXCOMP-258 to see which
> plugins/tools are affected.
>
> Kristian
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> For additional commands, e-mail: users-help@maven.apache.org
>
>


-- 
WBR
Maxim aka solomax

Re: Important Notice for all users of the parallel build feature

Posted by Kristian Rosenvold <kr...@gmail.com>.
The testcase was supplied by Chris Rompot in
http://jira.codehaus.org/browse/MASSEMBLY-684

The test failed with sufficiently high frequency that I could "easily"
track down the problem in a day or so.

The bug is twofold; it regards overlapping calls to Method#setVisible
between different threads, the singleton being the java.lang.Method
object. The additional problem is that plexus-interpolation basically
catches all these exceptions and puts these errors somewhere where
most clients dont even bother to check. In .21 I only fixed the
synchronization around setVisible, but I suppose we should also bring
the exception into daylight.

(We might simply just throw the exception instead....)

Kristian







2014-10-18 20:26 GMT+02:00 Igor Fedorenko <ig...@ifedorenko.com>:
> Kristian,
>
> Where can I find the test case and more information about the problem
> and the fix? Thank you in advance.
>
> --
> Regards,
> Igor
>
>
> On 2014-10-18, 14:22, Kristian Rosenvold wrote:
>>
>> Thanks to an excellent testcase provided by a JIRA user, a significant
>> source of thread safety bugs has been located and fixed. The problem
>> has an extensive reach, and can be the source of practically *any*
>> issue in parallel builds, and is probably the root cause of most JIRA
>> issues filed wrt parallel build problems.
>>
>> Fortunately, there is a very simple fix by putting the following
>> inside your plugin configuration:
>>
>>          <plugin>
>>            ...
>>            <dependencies>
>>              <dependency>
>>                <groupId>org.codehaus.plexus</groupId>
>>                <artifactId>plexus-interpolation</artifactId>
>>                <version>1.21</version>
>>              </dependency>
>>            </dependencies>
>>          </plugin>
>>
>>
>> You should also put this jar file in the lib/ext folder of your maven
>> installation:
>>
>>
>> http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-interpolation/1.21/plexus-interpolation-1.21.jar
>>
>>
>> Which plugins are affected ? It's almost easier to tell which is /not/
>> affected. See the "relates" link on
>> https://jira.codehaus.org/browse/PLXCOMP-258 to see which
>> plugins/tools are affected.
>>
>> Kristian
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: Important Notice for all users of the parallel build feature

Posted by Igor Fedorenko <ig...@ifedorenko.com>.
Kristian,

Where can I find the test case and more information about the problem
and the fix? Thank you in advance.

--
Regards,
Igor

On 2014-10-18, 14:22, Kristian Rosenvold wrote:
> Thanks to an excellent testcase provided by a JIRA user, a significant
> source of thread safety bugs has been located and fixed. The problem
> has an extensive reach, and can be the source of practically *any*
> issue in parallel builds, and is probably the root cause of most JIRA
> issues filed wrt parallel build problems.
>
> Fortunately, there is a very simple fix by putting the following
> inside your plugin configuration:
>
>          <plugin>
>            ...
>            <dependencies>
>              <dependency>
>                <groupId>org.codehaus.plexus</groupId>
>                <artifactId>plexus-interpolation</artifactId>
>                <version>1.21</version>
>              </dependency>
>            </dependencies>
>          </plugin>
>
>
> You should also put this jar file in the lib/ext folder of your maven
> installation:
>
> http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-interpolation/1.21/plexus-interpolation-1.21.jar
>
>
> Which plugins are affected ? It's almost easier to tell which is /not/
> affected. See the "relates" link on
> https://jira.codehaus.org/browse/PLXCOMP-258 to see which
> plugins/tools are affected.
>
> Kristian
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: Important Notice for all users of the parallel build feature

Posted by Kristian Rosenvold <kr...@gmail.com>.
Additionally, this issue affects parallel artifact download/pom
interpolation in maven core. The overall symptom is interpolation
expressions like ${project.name} not being resolved, but this can lead
to interesting kinds of corruption.

The fix can be applied to all 3.x versions of maven by dropping the
jar in lib/ext. 2.x is not affected.

Kristian


2014-10-18 20:22 GMT+02:00 Kristian Rosenvold <kr...@gmail.com>:
> Thanks to an excellent testcase provided by a JIRA user, a significant
> source of thread safety bugs has been located and fixed. The problem
> has an extensive reach, and can be the source of practically *any*
> issue in parallel builds, and is probably the root cause of most JIRA
> issues filed wrt parallel build problems.
>
> Fortunately, there is a very simple fix by putting the following
> inside your plugin configuration:
>
>         <plugin>
>           ...
>           <dependencies>
>             <dependency>
>               <groupId>org.codehaus.plexus</groupId>
>               <artifactId>plexus-interpolation</artifactId>
>               <version>1.21</version>
>             </dependency>
>           </dependencies>
>         </plugin>
>
>
> You should also put this jar file in the lib/ext folder of your maven
> installation:
>
> http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-interpolation/1.21/plexus-interpolation-1.21.jar
>
>
> Which plugins are affected ? It's almost easier to tell which is /not/
> affected. See the "relates" link on
> https://jira.codehaus.org/browse/PLXCOMP-258 to see which
> plugins/tools are affected.
>
> Kristian

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org


Re: Important Notice for all users of the parallel build feature

Posted by Kristian Rosenvold <kr...@gmail.com>.
Additionally, this issue affects parallel artifact download/pom
interpolation in maven core. The overall symptom is interpolation
expressions like ${project.name} not being resolved, but this can lead
to interesting kinds of corruption.

The fix can be applied to all 3.x versions of maven by dropping the
jar in lib/ext. 2.x is not affected.

Kristian


2014-10-18 20:22 GMT+02:00 Kristian Rosenvold <kr...@gmail.com>:
> Thanks to an excellent testcase provided by a JIRA user, a significant
> source of thread safety bugs has been located and fixed. The problem
> has an extensive reach, and can be the source of practically *any*
> issue in parallel builds, and is probably the root cause of most JIRA
> issues filed wrt parallel build problems.
>
> Fortunately, there is a very simple fix by putting the following
> inside your plugin configuration:
>
>         <plugin>
>           ...
>           <dependencies>
>             <dependency>
>               <groupId>org.codehaus.plexus</groupId>
>               <artifactId>plexus-interpolation</artifactId>
>               <version>1.21</version>
>             </dependency>
>           </dependencies>
>         </plugin>
>
>
> You should also put this jar file in the lib/ext folder of your maven
> installation:
>
> http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-interpolation/1.21/plexus-interpolation-1.21.jar
>
>
> Which plugins are affected ? It's almost easier to tell which is /not/
> affected. See the "relates" link on
> https://jira.codehaus.org/browse/PLXCOMP-258 to see which
> plugins/tools are affected.
>
> Kristian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org