You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by al...@apache.org on 2018/08/18 00:20:58 UTC

kudu git commit: [gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com

Repository: kudu
Updated Branches:
  refs/heads/master 37a81b82c -> 4ee1c4fd7


[gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com

This patch switches the URL to fetch gradle-wrapper.jar from
github.com to raw.githubusercontent.com. That's to be able to build
the Java part of the project at older Linux distros (RH < 7.4).

The github.com servers dropped TLSv1/TLSv1.1 support some time ago:
see [1] for details.

[1] https://githubengineering.com/crypto-removal-notice/

Change-Id: Ia745ef4d69726852fbe60be0d1778705d5580f14
Reviewed-on: http://gerrit.cloudera.org:8080/11262
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Alexey Serbin <as...@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/4ee1c4fd
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/4ee1c4fd
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/4ee1c4fd

Branch: refs/heads/master
Commit: 4ee1c4fd7a716182abbe4bab7a8a20089158a894
Parents: 37a81b8
Author: Alexey Serbin <as...@cloudera.com>
Authored: Fri Aug 17 13:21:14 2018 -0700
Committer: Alexey Serbin <as...@cloudera.com>
Committed: Sat Aug 18 00:17:05 2018 +0000

----------------------------------------------------------------------
 java/gradle/wrapper.gradle | 8 ++++++--
 java/gradlew               | 2 +-
 2 files changed, 7 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/4ee1c4fd/java/gradle/wrapper.gradle
----------------------------------------------------------------------
diff --git a/java/gradle/wrapper.gradle b/java/gradle/wrapper.gradle
index 56071a5..10171d5 100644
--- a/java/gradle/wrapper.gradle
+++ b/java/gradle/wrapper.gradle
@@ -51,8 +51,12 @@ task bootstrapWrapper() {
 
     // Add a trailing zero to the version if needed.
     def fullVersion = versions.gradle.count(".") == 1 ? "${versions.gradle}.0" : versions.gradle
-    // Leverages the wrapper jar checked into the gradle project on github because the jar isn't available elsewhere.
-    def wrapperBaseUrl = "https://github.com/gradle/gradle/raw/v$fullVersion/gradle/wrapper"
+    // Leverages the wrapper jar checked into the gradle project on github because the jar isn't
+    // available elsewhere. Using raw.githubusercontent.com instead of github.com because
+    // github.com servers deprecated TLSv1/TLSv1.1 support some time ago, so older versions
+    // of curl (built against OpenSSL library that doesn't support TLSv1.2) would fail to
+    // fetch the jar.
+    def wrapperBaseUrl = "https://raw.githubusercontent.com/gradle/gradle/v$fullVersion/gradle/wrapper"
     def wrapperJarUrl = wrapperBaseUrl + "/gradle-wrapper.jar"
 
     def bootstrapString = """

http://git-wip-us.apache.org/repos/asf/kudu/blob/4ee1c4fd/java/gradlew
----------------------------------------------------------------------
diff --git a/java/gradlew b/java/gradlew
index 3807ff4..f40bb25 100755
--- a/java/gradlew
+++ b/java/gradlew
@@ -82,7 +82,7 @@ esac
 # Loop in case we encounter an error.
 for attempt in 1 2 3; do
   if [ ! -e $APP_HOME/gradle/wrapper/gradle-wrapper.jar ]; then
-    if ! curl -s -S --retry 3 -L -o "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" "https://github.com/gradle/gradle/raw/v4.9.0/gradle/wrapper/gradle-wrapper.jar"; then
+    if ! curl -s -S --retry 3 -L -o "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" "https://raw.githubusercontent.com/gradle/gradle/v4.9.0/gradle/wrapper/gradle-wrapper.jar"; then
       rm -f "$APP_HOME/gradle/wrapper/gradle-wrapper.jar"
       # Pause for a bit before looping in case the server throttled us.
       sleep 5