You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/26 19:43:48 UTC

[GitHub] [incubator-superset] codecov-io commented on issue #8652: Pass full response to `query_cost_formatter`

codecov-io commented on issue #8652: Pass full response to `query_cost_formatter`
URL: https://github.com/apache/incubator-superset/pull/8652#issuecomment-558788429
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8652?src=pr&el=h1) Report
   > Merging [#8652](https://codecov.io/gh/apache/incubator-superset/pull/8652?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/acf0753504095a5c0e320b049370aaf6f04e5a4f?src=pr&el=desc) will **decrease** coverage by `0.04%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/8652/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8652?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #8652      +/-   ##
   ==========================================
   - Coverage   65.76%   65.71%   -0.05%     
   ==========================================
     Files         482      482              
     Lines       23824    23906      +82     
     Branches     2594     2617      +23     
   ==========================================
   + Hits        15667    15710      +43     
   - Misses       7984     8023      +39     
     Partials      173      173
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8652?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/8652/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `22.58% <0%> (-0.06%)` | :arrow_down: |
   | [...ssets/src/dashboard/util/activeDashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8652/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9hY3RpdmVEYXNoYm9hcmRGaWx0ZXJzLmpz) | `93.58% <0%> (+3.2%)` | :arrow_up: |
   | [.../assets/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8652/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9GaWx0ZXJCb3gvRmlsdGVyQm94LmpzeA==) | `10.36% <0%> (+4.43%)` | :arrow_up: |
   | [...src/dashboard/util/getFilterConfigsFromFormdata.js](https://codecov.io/gh/apache/incubator-superset/pull/8652/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXRGaWx0ZXJDb25maWdzRnJvbUZvcm1kYXRhLmpz) | `53.33% <0%> (+10.47%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8652?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8652?src=pr&el=footer). Last update [acf0753...42bc213](https://codecov.io/gh/apache/incubator-superset/pull/8652?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org